Bug 101007

Summary: Introduce ENABLE_DATE_AND_TIME_INPUT_TYPES, and clarify usage of other related flags
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, dglazkov, eric, haraken, japhet, mifenton, peter+ews, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100935    
Attachments:
Description Flags
Cook on EWS
none
Fix android build
none
Patch
none
Patch 2 haraken: review+

Kent Tamura
Reported 2012-11-01 19:01:44 PDT
ENABLE_DATE_AND_TIME_INPUT_TYPES is just an alias of ENABLE(INPUT_TYPE_DATE) || ENABLE(INPUT_TYPE_DATETIME) || ENABLE(INPUT_TYPE_DATETIMELOCAL) || ENABLE(INPUT_TYPE_MONTH) || ENABLE(INPUT_TYPE_TIME) || ENABLE(INPUT_TYPE_WEEK). ENABLE_CALENDAR_PICKER should mean "using WebCore/Resources/pagepopups/*.js"
Attachments
Cook on EWS (36.12 KB, patch)
2012-11-01 19:07 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Fix android build (37.13 KB, patch)
2012-11-01 20:26 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch (40.30 KB, patch)
2012-11-01 22:52 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (41.27 KB, patch)
2012-11-02 00:08 PDT, Kent Tamura 		haraken: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-11-01 19:07:59 PDT
Created attachment 171971 [details] Cook on EWS
Kent Tamura
Comment 2 2012-11-01 20:26:27 PDT
Created attachment 171981 [details] Fix android build
Peter Beverloo (cr-android ews)
Comment 3 2012-11-01 21:31:25 PDT
Comment on attachment 171981 [details] Fix android build Attachment 171981 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14693707
Kent Tamura
Comment 4 2012-11-01 22:52:43 PDT
Created attachment 171986 [details] Patch
Peter Beverloo (cr-android ews)
Comment 5 2012-11-01 23:58:42 PDT
Comment on attachment 171986 [details] Patch Attachment 171986 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14684724
Kent Tamura
Comment 6 2012-11-02 00:08:54 PDT
Created attachment 171991 [details] Patch 2 Android fix
Kentaro Hara
Comment 7 2012-11-02 04:11:03 PDT
Comment on attachment 171991 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=171991&action=review rs=me > Source/WebCore/ChangeLog:10 > + ENABLE_INPUT_MULTIPLE_FIELDS_UI is disabled. So they should be warpped Typo: wrapped > Source/WebCore/ChangeLog:32 > + 2) WebCore/Resources/pagepopus/ is used for the calendar UI implementation. Typo: pagepopups > Source/WebCore/ChangeLog:39 > + date/tiem InputType classes. Typo: date/time > Source/WebCore/ChangeLog:42 > + * page/ChromeClient.h: Change the flag for openDateTimChooser, and add a comment. Typo: openDateTimeChooser > Source/WebCore/ChangeLog:51 > + ENABEL(INPUT_MULTIPLE_FIELDS_UI). Typo: ENABLE > Source/WebCore/page/ChromeClient.h:233 > + // returns true, if ENABEL(INPUT_MULTIPLE_FIELDS_UI) Typo: ENABLE > Source/WebCore/page/ChromeClient.h:235 > + // ENABEL(INPUT_MULTIPLE_FIELDS_UI) Typo: ENABLE > Source/WebCore/platform/text/PlatformLocale.cpp:351 > + Nit: A redundant empty line.
Kent Tamura
Comment 8 2012-11-02 04:14:50 PDT
oops, thank you for pointing out a lot of typos :-(
Kent Tamura
Comment 9 2012-11-02 04:28:13 PDT
Committed r133284: <http://trac.webkit.org/changeset/133284>
Note You need to log in before you can comment on or make changes to this bug.