Bug 101086

Summary: [CSS Exclusions] Implement text alignment for shape-inside
Product: WebKit Reporter: Bear Travis <betravis>
Component: CSSAssignee: Bear Travis <betravis>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, donggwan.kim, stearns
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89256    
Attachments:
Description Flags
Initial Patch, Adding Tests
none
Fixing style issues
achicu: review+
Minor adjustment none

Bear Travis
Reported 2012-11-02 12:17:53 PDT
Specifically for multi-segment polygons, this can be complex.
Attachments
Initial Patch, Adding Tests (8.68 KB, patch)
2013-06-13 16:29 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
Fixing style issues (8.69 KB, patch)
2013-06-13 16:34 PDT, Bear Travis 		achicu: review+
DetailsFormatted DiffDiff
Minor adjustment (8.66 KB, patch)
2013-06-14 16:03 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alan Stearns
Comment 1 2013-02-20 07:26:55 PST
Add tests for all alignments (particularly justified) with this fix.
Bear Travis
Comment 2 2013-06-13 16:29:23 PDT
Created attachment 204651 [details] Initial Patch, Adding Tests
WebKit Commit Bot
Comment 3 2013-06-13 16:31:17 PDT
Attachment 204651 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/exclusions/resources/multi-segment-polygon.js', u'LayoutTests/fast/exclusions/shape-inside/shape-inside-text-align-expected.html', u'LayoutTests/fast/exclusions/shape-inside/shape-inside-text-align.html']" exit_code: 1 LayoutTests/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Bear Travis
Comment 4 2013-06-13 16:34:41 PDT
Created attachment 204652 [details] Fixing style issues
Alexandru Chiculita
Comment 5 2013-06-14 14:25:49 PDT
Comment on attachment 204652 [details] Fixing style issues View in context: https://bugs.webkit.org/attachment.cgi?id=204652&action=review looks good. > LayoutTests/fast/exclusions/shape-inside/shape-inside-text-align-expected.html:6 > +<script> > +</script> nit: you forgot this empty script.
Bear Travis
Comment 6 2013-06-14 16:03:41 PDT
Created attachment 204741 [details] Minor adjustment
WebKit Commit Bot
Comment 7 2013-06-17 11:54:16 PDT
Comment on attachment 204741 [details] Minor adjustment Clearing flags on attachment: 204741 Committed r151650: <http://trac.webkit.org/changeset/151650>
WebKit Commit Bot
Comment 8 2013-06-17 11:54:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.