Bug 101196

Summary: [Chromium] Add API to expose WebCore::DateTimeChooser
Product: WebKit Reporter: Kent Tamura <tkent>
Component: WebKit Misc.Assignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, morrita, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100935    
Attachments:
Description Flags
WIP
none
Patch none

Kent Tamura
Reported 2012-11-05 02:13:15 PST
[Chromium] Add API to expose WebCore::DateTimeChooser
Attachments
WIP (11.14 KB, patch)
2012-11-05 02:16 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch (21.59 KB, patch)
2012-11-05 23:43 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-11-05 02:16:15 PST
Created attachment 172297 [details] WIP
Kent Tamura
Comment 2 2012-11-05 23:43:58 PST
Created attachment 172494 [details] Patch
WebKit Review Bot
Comment 3 2012-11-05 23:46:04 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Hajime Morrita
Comment 4 2012-11-13 23:39:20 PST
Comment on attachment 172494 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172494&action=review > Source/WebKit/chromium/src/ExternalDateTimeChooser.cpp:43 > + : m_chooser(chooser) Is this safe to assume that ExternalDateTimeChooser lives longer than WebDateTimeChooserCompletition? It looks DateTimeChooser is owned by an InputType subclass, which looks to have shorter lifetime. Maybe modality guarantees this lifetime assumption?
Kent Tamura
Comment 5 2012-11-13 23:44:59 PST
Comment on attachment 172494 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172494&action=review >> Source/WebKit/chromium/src/ExternalDateTimeChooser.cpp:43 >> + : m_chooser(chooser) > > Is this safe to assume that ExternalDateTimeChooser lives longer than WebDateTimeChooserCompletition? > It looks DateTimeChooser is owned by an InputType subclass, which looks to have shorter lifetime. > Maybe modality guarantees this lifetime assumption? It's safe because ExternalDateTimeChooser is RefCounted and WebDateTimeChooserCompletitionImpl holds one reference of ExternalDateTimeChooser. A InputType subclass holds another reference.
Hajime Morrita
Comment 6 2012-11-13 23:49:08 PST
Comment on attachment 172494 [details] Patch Right.
WebKit Review Bot
Comment 7 2012-11-14 00:09:02 PST
Comment on attachment 172494 [details] Patch Clearing flags on attachment: 172494 Committed r134560: <http://trac.webkit.org/changeset/134560>
WebKit Review Bot
Comment 8 2012-11-14 00:09:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.