Bug 101556

Summary: Add tests for month picker
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100938    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Keishi Hattori
Reported 2012-11-07 23:46:49 PST
Add tests for month picker
Attachments
Patch (76.42 KB, patch)
2012-11-09 03:49 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (76.42 KB, patch)
2012-11-11 20:44 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (76.55 KB, patch)
2012-11-11 23:23 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-11-09 03:49:17 PST
Created attachment 173259 [details] Patch
Keishi Hattori
Comment 2 2012-11-11 20:44:31 PST
Created attachment 173544 [details] Patch
Kent Tamura
Comment 3 2012-11-11 21:10:58 PST
Comment on attachment 173544 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173544&action=review > LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:80 > + eventSender.keyDown('\n'); > + shouldBeNull('document.getElementById("mock-page-popup")'); Unfortunately this doesn't work any more because popup close operation is now asynchronous. http://trac.webkit.org/changeset/134180 > LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:102 > + eventSender.keyDown('\x1B'); > + shouldBeNull('document.getElementById("mock-page-popup")'); ditto. > LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations.html:44 > + clickElement(popupWindow.document.querySelectorAll(".day:not(.week-column)")[6]); > + shouldBeNull('document.getElementById("mock-page-popup")'); Ditto. > LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-with-step.html:31 > + // Close popup > + eventSender.keyDown('\x1B'); > + > + document.getElementById('month').min = "2011-05"; > + document.getElementById('month').value = "2012-02"; > + > + // Reopen popup > + openPicker(document.getElementById('month'), test2); ditto.
Keishi Hattori
Comment 4 2012-11-11 23:23:59 PST
Created attachment 173569 [details] Patch
Kent Tamura
Comment 5 2012-11-12 00:27:43 PST
Comment on attachment 173569 [details] Patch looks good
WebKit Review Bot
Comment 6 2012-11-12 04:32:34 PST
Comment on attachment 173569 [details] Patch Clearing flags on attachment: 173569 Committed r134209: <http://trac.webkit.org/changeset/134209>
WebKit Review Bot
Comment 7 2012-11-12 04:32:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.