Bug 102065

Summary: [EFL][WK2] Add a button parameter to mouseClick, mouseDown, mouseUp functions
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: lucas.de.marchi, rakuco, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 96200    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Gyuyoung Kim
Reported 2012-11-13 02:53:03 PST
mouseClick() test function's only able to test a left button of mouse now. However, EFL API test framwork needs to test various mouse buttons. For example, context menu test needs to simulate a right mouse button.
Attachments
Patch (9.60 KB, patch)
2012-11-13 02:55 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (3.05 KB, patch)
2012-11-13 08:33 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (4.10 KB, patch)
2012-11-13 08:57 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (4.09 KB, patch)
2012-11-13 18:23 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-11-13 02:55:17 PST
Created attachment 173855 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-11-13 04:46:47 PST
Comment on attachment 173855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173855&action=review > Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:50 > - void mouseClick(int x, int y); > + void mouseClick(int x, int y, int button); Instead of adding 1 to all calls in the unit tests, you can just make it the default here: void mouseClick(int x, int y, int button = 1);
Gyuyoung Kim
Comment 3 2012-11-13 08:33:22 PST
Created attachment 173901 [details] Patch
Gyuyoung Kim
Comment 4 2012-11-13 08:34:37 PST
(In reply to comment #2) > Instead of adding 1 to all calls in the unit tests, you can just make it the default here: > void mouseClick(int x, int y, int button = 1); I missed this. Thanks.
Raphael Kubo da Costa (:rakuco)
Comment 5 2012-11-13 08:44:45 PST
Comment on attachment 173901 [details] Patch LGTM. Don't mouseDown() and mouseUp() need to be changed as well?
Gyuyoung Kim
Comment 6 2012-11-13 08:57:22 PST
Created attachment 173905 [details] Patch
Gyuyoung Kim
Comment 7 2012-11-13 08:59:53 PST
(In reply to comment #5) > (From update of attachment 173901 [details]) > LGTM. Don't mouseDown() and mouseUp() need to be changed as well? mouseClick() is enough for me. But, I also think other functions need to have the button parameter as well. Thanks.
Chris Dumez
Comment 8 2012-11-13 10:19:57 PST
Comment on attachment 173905 [details] Patch LGTM.
Laszlo Gombos
Comment 9 2012-11-13 18:14:43 PST
Comment on attachment 173905 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173905&action=review r=me. > Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:50 > + void mouseClick(int x, int y, int button = 1); Maybe we can add the comment here, instead of removing it void mouseClick(int x, int y, int button = 1 /* Left */);
Gyuyoung Kim
Comment 10 2012-11-13 18:23:56 PST
Created attachment 174047 [details] Patch
WebKit Review Bot
Comment 11 2012-11-13 21:46:15 PST
Comment on attachment 174047 [details] Patch Clearing flags on attachment: 174047 Committed r134540: <http://trac.webkit.org/changeset/134540>
WebKit Review Bot
Comment 12 2012-11-13 21:46:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.