Bug 102289

Summary: Cleanup BasicShape blending check
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CSSAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95389    
Attachments:
Description Flags
Patch dbates: review+

Dirk Schulze
Reported 2012-11-14 14:56:56 PST
We have the same checks if two BasicShape objects can be blended twice. Refactor the code and add a canBlend method in BasicShape that combined the check.
Attachments
Patch (4.28 KB, patch)
2012-11-14 15:18 PST, Dirk Schulze 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2012-11-14 15:18:27 PST
Created attachment 174268 [details] Patch
Eric Seidel (no email)
Comment 2 2012-11-14 15:25:13 PST
Comment on attachment 174268 [details] Patch The double-negatives are a bit confusing. But this looks right.
Dirk Schulze
Comment 3 2012-11-14 15:27:53 PST
Committed r134679: <http://trac.webkit.org/changeset/134679>
Note You need to log in before you can comment on or make changes to this bug.