Bug 103502

Summary: Node::compareDocumentPosition returns wrong value for a node in the different shadow tree.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: DOMAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: ojan, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 72352    
Attachments:
Description Flags
Fix Node::compareDocumentPosition for nodes in shadow tree. none

Hayato Ito
Reported 2012-11-28 04:01:51 PST
According to the spec (http://dom.spec.whatwg.org/#dom-node-comparedocumentposition), if two nodes are not in the same tree, we should return DOCUMENT_POSITION_DISCONNECTED, DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC. But the current implementation mays not return that for nodes which are in different shadow trees.
Attachments
Fix Node::compareDocumentPosition for nodes in shadow tree. (7.05 KB, patch)
2012-11-28 05:49 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-11-28 05:49:46 PST
Created attachment 176468 [details] Fix Node::compareDocumentPosition for nodes in shadow tree.
WebKit Review Bot
Comment 2 2012-11-28 19:18:40 PST
Comment on attachment 176468 [details] Fix Node::compareDocumentPosition for nodes in shadow tree. Clearing flags on attachment: 176468 Committed r136087: <http://trac.webkit.org/changeset/136087>
WebKit Review Bot
Comment 3 2012-11-28 19:18:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.