Bug 108525

Summary:

[Mac] Enable spellchecking tests added in r141471

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, darin, enrica, g.czajkowski, gyuyoung.kim, jiapu.mail, rakuco, rniwa, rouslan+webkit, tony, webkit-bug-importer, webkit-ews

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

108498, 114337

Bug Blocks:

114470

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Work in progress	none
Work in progress 2	none
Fixes, removes, and re-enables tests as needed	none
Fixed builds	none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2	none
Added a failing expectation on WebKit2	none

Ryosuke Niwa

Reported 2013-01-31 14:22:32 PST

http://trac.webkit.org/changeset/141471 added a whole bunch of spellchecking tests. We should enable these on Mac.

Attachments
Patch (14.20 KB, patch) 2013-01-31 16:33 PST, Rouslan Solomakhin	no flags	Details Formatted Diff Diff
Patch (14.33 KB, patch) 2013-02-01 13:01 PST, Rouslan Solomakhin	no flags	Details Formatted Diff Diff
Patch (3.22 KB, patch) 2013-02-04 10:01 PST, Rouslan Solomakhin	no flags	Details Formatted Diff Diff
Work in progress (8.60 KB, patch) 2013-04-09 20:47 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Work in progress 2 (13.69 KB, patch) 2013-04-10 00:29 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Fixes, removes, and re-enables tests as needed (44.91 KB, patch) 2013-04-11 15:59 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Fixed builds (44.92 KB, patch) 2013-04-11 16:18 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (1.01 MB, application/zip) 2013-04-11 18:31 PDT, Build Bot	no flags	Details
Added a failing expectation on WebKit2 (45.69 KB, patch) 2013-04-11 18:55 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Rouslan Solomakhin

Comment 1 2013-01-31 16:33:15 PST

Created attachment 185891 [details] Patch

Rouslan Solomakhin

Comment 2 2013-01-31 17:13:31 PST

Comment on attachment 185891 [details] Patch Need to merge this with the change from bug 108509, when it lands.

Rouslan Solomakhin

Comment 3 2013-02-01 13:01:10 PST

Created attachment 186114 [details] Patch

Ryosuke Niwa

Comment 4 2013-02-01 13:02:29 PST

Thanks for the patch! Let's see what mac & mac-wk2 EWS have to say.

Ryosuke Niwa

Comment 5 2013-02-03 14:24:43 PST

Comment on attachment 186114 [details] Patch I don't think we want to enable tests with FAILs in them.

Tony Chang

Comment 6 2013-02-04 09:53:32 PST

(In reply to comment #5) > (From update of attachment 186114 [details]) > I don't think we want to enable tests with FAILs in them. Oh, I thought for Mac we preferred to check in failing expected results over Skip lines in TestExpectations. I don't have a strong preference of what we should do for failing tests on Mac-- I suggested this to rouslan because I thought this was how we handled Mac failures.

Rouslan Solomakhin

Comment 7 2013-02-04 10:01:27 PST

Created attachment 186408 [details] Patch

Rouslan Solomakhin

Comment 8 2013-02-04 10:02:39 PST

Comment on attachment 186408 [details] Patch Instead of checking in the expected test outputs for failure, I changed [Skip] to [Failure] in TestExpectations for failing spellcheck tests. For passing spellcheck tests, I removed the [Skip] lines in TestExpectations.

Rouslan Solomakhin

Comment 9 2013-02-22 17:36:50 PST

Howdy folks. I plan to move these tests into editing/spelling/unified-async, so that platforms can enable these tests when/if they implement unified text checking and async spell checking. Is it alright if I close this bug as WontFix?

Ryosuke Niwa

Comment 10 2013-02-22 17:39:02 PST

(In reply to comment #9) > Howdy folks. I plan to move these tests into editing/spelling/unified-async, so that platforms can enable these tests when/if they implement unified text checking and async spell checking. Is it alright if I close this bug as WontFix? I don't think that makes sense. There's no reason these tests should fail on non-async implementation of spellchecks.

Ryosuke Niwa

Comment 11 2013-04-09 20:47:14 PDT

Created attachment 197199 [details] Work in progress

Ryosuke Niwa

Comment 12 2013-04-10 00:29:27 PDT

Created attachment 197218 [details] Work in progress 2

Radar WebKit Bug Importer

Comment 13 2013-04-10 02:14:16 PDT

<rdar://problem/13618029>

Ryosuke Niwa

Comment 14 2013-04-11 15:59:08 PDT

Created attachment 197685 [details] Fixes, removes, and re-enables tests as needed

EFL EWS Bot

Comment 15 2013-04-11 16:08:51 PDT

Comment on attachment 197685 [details] Fixes, removes, and re-enables tests as needed Attachment 197685 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/106013

Early Warning System Bot

Comment 16 2013-04-11 16:13:18 PDT

Comment on attachment 197685 [details] Fixes, removes, and re-enables tests as needed Attachment 197685 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-queues.appspot.com/results/105015

Ryosuke Niwa

Comment 17 2013-04-11 16:18:32 PDT

Created attachment 197695 [details] Fixed builds

Build Bot

Comment 18 2013-04-11 18:31:53 PDT

Comment on attachment 197695 [details] Fixed builds Attachment 197695 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/105051 New failing tests: editing/spelling/spelling-changed-text.html

Build Bot

Comment 19 2013-04-11 18:31:56 PDT

Created attachment 197707 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2

Ryosuke Niwa

Comment 20 2013-04-11 18:55:48 PDT

Created attachment 197709 [details] Added a failing expectation on WebKit2

WebKit Commit Bot

Comment 21 2013-04-12 09:51:15 PDT

Comment on attachment 197709 [details] Added a failing expectation on WebKit2 Clearing flags on attachment: 197709 Committed r148282: <http://trac.webkit.org/changeset/148282>

WebKit Commit Bot

Comment 22 2013-04-12 09:51:20 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.