Bug 111142

Summary: Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, benjamin, dpranke, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77037    
Attachments:
Description Flags
Cleanup abarth: review+

Ryosuke Niwa
Reported 2013-02-28 22:18:45 PST
Another refactoring. _run_single_test and _run_tests_set should be a single method.
Attachments
Cleanup (5.73 KB, patch)
2013-02-28 22:22 PST, Ryosuke Niwa 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-02-28 22:22:04 PST
Created attachment 190885 [details] Cleanup
Adam Barth
Comment 2 2013-02-28 22:32:03 PST
Comment on attachment 190885 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=190885&action=review > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:371 > + _log.error('FAILED') I guess we don't say which test failed.
Ryosuke Niwa
Comment 3 2013-02-28 22:35:39 PST
Comment on attachment 190885 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=190885&action=review >> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:371 >> + _log.error('FAILED') > > I guess we don't say which test failed. Ordinarily, we see the test name right above it: Running DOM/CreateNodes.html (32 of 113) error: DOM/CreateNodes.html Received an invalid message "WebPageProxy.DidFailProvisionalLoadForFrame" from the web process. FAILED Finished: 18.626504 s
Ryosuke Niwa
Comment 4 2013-02-28 22:36:16 PST
Committed r144421: <http://trac.webkit.org/changeset/144421>
Note You need to log in before you can comment on or make changes to this bug.