Bug 117649

Summary:

[GTK][WK2] adding subtitles (with toggle button) on html videos

Product:

WebKit

Reporter:

Danilo de Paula <danilo.eu>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

buildbot, cgarcia, commit-queue, eric.carlson, esprehn+autocc, glenn, gustavo, jer.noble, macpherson, menard, mrobinson, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

117177

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2	none

Danilo de Paula

Reported 2013-06-14 12:07:48 PDT

[GTK][WK2] adding subtitles (with toggle button) on html videos

Attachments
Patch (5.25 KB, patch) 2013-06-14 12:08 PDT, Danilo de Paula	no flags	Details Formatted Diff Diff
Patch (5.29 KB, patch) 2013-06-14 12:10 PDT, Danilo de Paula	no flags	Details Formatted Diff Diff
Patch (5.89 KB, text/plain) 2013-06-17 05:45 PDT, Danilo de Paula	buildbot: commit-queue-	Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (501.48 KB, application/zip) 2013-06-17 07:05 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (578.15 KB, application/zip) 2013-06-17 07:50 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (768.26 KB, application/zip) 2013-06-17 11:02 PDT, Build Bot	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Danilo de Paula

Comment 1 2013-06-14 12:08:08 PDT

Created attachment 204728 [details] Patch

WebKit Commit Bot

Comment 2 2013-06-14 12:10:12 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Danilo de Paula

Comment 3 2013-06-14 12:10:13 PDT

Created attachment 204729 [details] Patch

Carlos Garcia Campos

Comment 4 2013-06-16 23:51:39 PDT

Comment on attachment 204729 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204729&action=review Thanks for the patch. > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1163 > + settings->priv->preferences->setShouldDisplaySubtitles(TRUE); It should be true, not TRUE. If we want to enable this unconditionally, this is not the place to do it. You should change the default value of the setting for the GTK platform in Shared/WebPreferencesStore.h

Danilo de Paula

Comment 5 2013-06-17 05:45:07 PDT

Created attachment 204812 [details] Patch

Danilo de Paula

Comment 6 2013-06-17 05:49:48 PDT

Comment on attachment 204812 [details] Patch wrong file here...

Build Bot

Comment 7 2013-06-17 07:05:05 PDT

Comment on attachment 204812 [details] Patch Attachment 204812 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/929029 New failing tests: media/video-controls-captions-trackmenu-hide-on-click.html fast/repaint/table-cell-collapsed-border-scroll.html media/video-controls-captions-trackmenu-hide-on-click-outside.html

Build Bot

Comment 8 2013-06-17 07:05:08 PDT

Created attachment 204820 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.3

Build Bot

Comment 9 2013-06-17 07:50:24 PDT

Comment on attachment 204812 [details] Patch Attachment 204812 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/895141 New failing tests: media/video-controls-captions-trackmenu-hide-on-click.html fast/repaint/table-cell-collapsed-border-scroll.html media/video-controls-captions-trackmenu-hide-on-click-outside.html

Build Bot

Comment 10 2013-06-17 07:50:28 PDT

Created attachment 204822 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.3

Build Bot

Comment 11 2013-06-17 11:02:50 PDT

Comment on attachment 204812 [details] Patch Attachment 204812 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/857391 New failing tests: media/video-controls-captions-trackmenu-hide-on-click.html media/video-controls-captions-trackmenu-hide-on-click-outside.html

Build Bot

Comment 12 2013-06-17 11:02:53 PDT

Created attachment 204839 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3

Danilo de Paula

Comment 13 2013-08-18 05:52:23 PDT

Subtitles support on webkitgtk is being handled by https://bugs.webkit.org/show_bug.cgi?id=117008 *** This bug has been marked as a duplicate of bug 117008 ***

Note You need to log in before you can comment on or make changes to this bug.