Bug 120221

Summary: copy-webkitlibraries-to-product-directory should accept command-line arguments for extra work required for optional features rather than relying on environment variables
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Tools / TestsAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: mrowe, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 112840    
Attachments:
Description Flags
the patch mhahnenberg: review+

Filip Pizlo
Reported 2013-08-23 12:25:22 PDT
Using environment variables is a bit too magical - it's never quite clear who sets the environment variable or who consumes it. An argument is more explicit.
Attachments
the patch (4.84 KB, patch)
2014-01-30 16:28 PST, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-01-30 16:28:05 PST
Created attachment 222756 [details] the patch
Mark Hahnenberg
Comment 2 2014-01-30 16:33:37 PST
Comment on attachment 222756 [details] the patch r=me
Filip Pizlo
Comment 3 2014-01-30 16:37:55 PST
Landed in http://trac.webkit.org/changeset/163133
Note You need to log in before you can comment on or make changes to this bug.