Bug 120890

Summary: Concurrent FTL causes !hasOptimizedReplacement() asserts in cti_optimize
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 112840    
Attachments:
Description Flags
the patch fpizlo: review+

Filip Pizlo
Reported 2013-09-06 13:12:56 PDT
This is because the FTL may install an optimized replacement while the DFG has already been jettisoned - so then the baseline JIT's cti_optimize sees an on-going DFG compile to reoptimize the code while also seeing an FTL optimized replacement.
Attachments
the patch (1.62 KB, patch)
2013-09-06 13:13 PDT, Filip Pizlo 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-09-06 13:13:51 PDT
Created attachment 210786 [details] the patch
Filip Pizlo
Comment 2 2013-09-06 13:17:16 PDT
Comment on attachment 210786 [details] the patch r=mark
Filip Pizlo
Comment 3 2013-09-06 13:19:32 PDT
Landed in http://trac.webkit.org/changeset/155209
Note You need to log in before you can comment on or make changes to this bug.