Bug 122178

Summary: Variable event stream (for DFG OSR exit) should be explicit about where on the stack a SetLocal put a value
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, eflews.bot, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 122024    
Attachments:
Description Flags
work in progress
none
the patch ggaren: review+, eflews.bot: commit-queue-

Filip Pizlo
Reported 2013-10-01 14:16:25 PDT
Patch forthcoming.
Attachments
work in progress (25.13 KB, patch)
2013-10-01 14:21 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (31.62 KB, patch)
2013-10-01 14:35 PDT, Filip Pizlo 		ggaren: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-10-01 14:16:37 PDT
*** Bug 108019 has been marked as a duplicate of this bug. ***
Filip Pizlo
Comment 2 2013-10-01 14:21:09 PDT
Created attachment 213119 [details] work in progress
Filip Pizlo
Comment 3 2013-10-01 14:35:56 PDT
Created attachment 213121 [details] the patch
Geoffrey Garen
Comment 4 2013-10-01 14:55:35 PDT
Comment on attachment 213121 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=213121&action=review r=me > Source/JavaScriptCore/dfg/DFGVariableEvent.h:234 > + return static_cast<VirtualRegister>(m_representation.virtualReg); You can just use constructor syntax here: VirtualRegister(m_representation.virtualReg). > Source/JavaScriptCore/dfg/DFGVariableEvent.h:240 > + return static_cast<VirtualRegister>(m_representation.virtualReg); Ditto. > Source/JavaScriptCore/dfg/DFGVariableEvent.h:246 > + return static_cast<VirtualRegister>(m_which.virtualReg); You can just use constructor syntax here: VirtualRegister(m_which.virtualReg).
EFL EWS Bot
Comment 5 2013-10-01 15:17:15 PDT
Comment on attachment 213121 [details] the patch Attachment 213121 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/2902186
Filip Pizlo
Comment 6 2013-10-01 16:00:53 PDT
(In reply to comment #5) > (From update of attachment 213121 [details]) > Attachment 213121 [details] did not pass efl-wk2-ews (efl-wk2): > Output: http://webkit-queues.appspot.com/results/2902186 Looks like an ICE. Not my problem.
Filip Pizlo
Comment 7 2013-10-01 16:29:21 PDT
Landed in http://trac.webkit.org/changeset/156747
Note You need to log in before you can comment on or make changes to this bug.