Bug 122210

Summary: Remove Qt bots and EWS from trunk.
Product: WebKit Reporter: Ádám Kallai <kadam>
Component: Tools / TestsAssignee: Ádám Kallai <kadam>
Status: RESOLVED FIXED    
Severity: Normal CC: abrhm, allan.jensen, andersca, commit-queue, dpranke, glenn, jbriance, jturcotte, lforschler, ossy, rniwa, wsiegrist, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=85887
Bug Depends on:    
Bug Blocks: 122167    
Attachments:
Description Flags
patch
ossy: review-, ossy: commit-queue-
patch
none
patch allan.jensen: review+

Ádám Kallai
Reported 2013-10-02 03:05:40 PDT
I'm going to remove Qt bots and EWS from trunk.
Attachments
patch (19.71 KB, patch)
2013-10-02 03:27 PDT, Ádám Kallai 		ossy: review-
ossy: commit-queue-
DetailsFormatted DiffDiff
patch (20.15 KB, patch)
2013-10-02 05:31 PDT, Ádám Kallai 		no flags
DetailsFormatted DiffDiff
patch (19.75 KB, patch)
2013-10-02 05:38 PDT, Ádám Kallai 		allan.jensen: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ádám Kallai
Comment 1 2013-10-02 03:27:30 PDT
Created attachment 213160 [details] patch Patch for remove Qt bots and EWS.
Zoltan Arvai
Comment 2 2013-10-02 05:03:14 PDT
Comment on attachment 213160 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=213160&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-770 > - if not platform.startswith("qt"): It seems this one is for non-qt slaves. Probably the self.addStep(KillOldProcesses()) is required for non-qt bots.
Csaba Osztrogonác
Comment 3 2013-10-02 05:24:00 PDT
Comment on attachment 213160 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=213160&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-770 >> - if not platform.startswith("qt"): > > It seems this one is for non-qt slaves. Probably the self.addStep(KillOldProcesses()) is required for non-qt bots. good catch. :) self.addStep(KillOldProcesses()) should run unconditionally. Please fix it.
Ádám Kallai
Comment 4 2013-10-02 05:26:08 PDT
Thanks. I fix it asap.
Ádám Kallai
Comment 5 2013-10-02 05:31:06 PDT
Created attachment 213164 [details] patch Proposal patch.
Ádám Kallai
Comment 6 2013-10-02 05:33:46 PDT
Comment on attachment 213164 [details] patch I uploaded wrong patch.
Ádám Kallai
Comment 7 2013-10-02 05:38:17 PDT
Created attachment 213165 [details] patch proposal patch.
Allan Sandfeld Jensen
Comment 8 2013-10-02 08:02:42 PDT
Comment on attachment 213165 [details] patch LGTM. rniwa?
Lucas Forschler
Comment 9 2013-10-02 08:24:14 PDT
This looks ok to me. However, I would prefer two separate patches. One for the buildbot config, and one to remove EWS, as they are two separate systems.
Lucas Forschler
Comment 10 2013-10-02 08:24:52 PDT
Please coordinate with me for a master restart once this lands.
Anders Carlsson
Comment 11 2013-10-02 10:07:08 PDT
I’ll land these in two steps and let Lucas know.
Anders Carlsson
Comment 12 2013-10-02 10:12:24 PDT
EWS bots have been removed in r156770.
Anders Carlsson
Comment 13 2013-10-02 10:14:54 PDT
Bots have been removed in r156771.
Note You need to log in before you can comment on or make changes to this bug.