Bug 125144

Summary:

[CSS Regions] Enable accelerated compositing for fixed elements in named flows

Product:

WebKit

Reporter:

Mihnea Ovidenie <mihnea>

Component:

CSS

Assignee:

Mihnea Ovidenie <mihnea>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, WebkitBugTracker

Priority:

Keywords:

AdobeTracked

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

57312, 84900

Attachments:

Description	Flags
WIP1	none
WIP2	none
WIP3	none
Patch	none
Patch 2	none
Patch for landing	none

Mihnea Ovidenie

Reported 2013-12-03 02:18:14 PST

The fix for https://bugs.webkit.org/show_bug.cgi?id=111176 allowed fixed positioned elements inside a named flow to be positioned/sized properly relative to viewport instead of first region in the chain. The next step is to enable these elements to become composited too on platforms supporting compositing (similar to the fixed elements that are not inside a named flow).

Attachments
WIP1 (42.98 KB, patch) 2013-12-15 08:35 PST, Mihnea Ovidenie	no flags	Details Formatted Diff Diff
WIP2 (40.07 KB, patch) 2014-01-13 08:56 PST, Mihnea Ovidenie	no flags	Details Formatted Diff Diff
WIP3 (48.01 KB, patch) 2014-01-14 01:52 PST, Mihnea Ovidenie	no flags	Details Formatted Diff Diff
Patch (53.58 KB, patch) 2014-01-15 00:49 PST, Mihnea Ovidenie	no flags	Details Formatted Diff Diff
Patch 2 (53.57 KB, patch) 2014-01-15 07:09 PST, Mihnea Ovidenie	no flags	Details Formatted Diff Diff
Patch for landing (55.95 KB, patch) 2014-01-15 22:53 PST, Mihnea Ovidenie	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Mihnea Ovidenie

Comment 1 2013-12-15 08:35:02 PST

Created attachment 219278 [details] WIP1

Mihnea Ovidenie

Comment 2 2014-01-13 08:56:37 PST

Created attachment 221051 [details] WIP2

Mihnea Ovidenie

Comment 3 2014-01-14 01:52:50 PST

Created attachment 221129 [details] WIP3

Mihnea Ovidenie

Comment 4 2014-01-15 00:49:50 PST

Created attachment 221238 [details] Patch

WebKit Commit Bot

Comment 5 2014-01-15 00:50:51 PST

Attachment 221238 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/compositing/regions/abs-in-named-flow-from-fixed-in-named-flow-expected.txt', u'LayoutTests/compositing/regions/abs-in-named-flow-from-fixed-in-named-flow.html', u'LayoutTests/compositing/regions/fixed-in-diff-named-flows-zIndex-expected.html', u'LayoutTests/compositing/regions/fixed-in-diff-named-flows-zIndex.html', u'LayoutTests/compositing/regions/fixed-in-named-flow-clip-descendant-expected.txt', u'LayoutTests/compositing/regions/fixed-in-named-flow-clip-descendant.html', u'LayoutTests/compositing/regions/fixed-in-named-flow-expected.txt', u'LayoutTests/compositing/regions/fixed-in-named-flow-from-abs-in-named-flow-expected.txt', u'LayoutTests/compositing/regions/fixed-in-named-flow-from-abs-in-named-flow.html', u'LayoutTests/compositing/regions/fixed-in-named-flow-from-outflow-expected.txt', u'LayoutTests/compositing/regions/fixed-in-named-flow-from-outflow.html', u'LayoutTests/compositing/regions/fixed-in-named-flow-got-transformed-parent-expected.txt', u'LayoutTests/compositing/regions/fixed-in-named-flow-got-transformed-parent.html', u'LayoutTests/compositing/regions/fixed-in-named-flow-lost-transformed-parent-expected.txt', u'LayoutTests/compositing/regions/fixed-in-named-flow-lost-transformed-parent.html', u'LayoutTests/compositing/regions/fixed-in-named-flow-overlap-composited-expected.txt', u'LayoutTests/compositing/regions/fixed-in-named-flow-overlap-composited.html', u'LayoutTests/compositing/regions/fixed-in-named-flow-position-changed-expected.html', u'LayoutTests/compositing/regions/fixed-in-named-flow-position-changed.html', u'LayoutTests/compositing/regions/fixed-in-named-flow-transformed-parent-expected.txt', u'LayoutTests/compositing/regions/fixed-in-named-flow-transformed-parent.html', u'LayoutTests/compositing/regions/fixed-in-named-flow-zIndex-expected.html', u'LayoutTests/compositing/regions/fixed-in-named-flow-zIndex.html', u'LayoutTests/compositing/regions/fixed-in-named-flow.html', u'LayoutTests/compositing/regions/fixed-transformed-in-named-flow-expected.txt', u'LayoutTests/compositing/regions/fixed-transformed-in-named-flow.html', u'LayoutTests/fast/regions/repaint/element-in-named-flow-absolute-from-fixed.html', u'LayoutTests/fast/regions/repaint/element-in-named-flow-fixed-from-absolute.html', u'LayoutTests/fast/regions/repaint/element-inflow-fixed-from-outflow-static.html', u'LayoutTests/fast/regions/repaint/element-outflow-static-from-inflow-fixed.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.h', u'Source/WebCore/rendering/RenderNamedFlowFragment.h', u'Source/WebCore/rendering/RenderNamedFlowThread.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/rendering/RenderLayerCompositor.h:345: The parameter name "overlapMap" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 36 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mihnea Ovidenie

Comment 6 2014-01-15 07:09:10 PST

Created attachment 221267 [details] Patch 2 Same patch but try to make style checker happy.

Dave Hyatt

Comment 7 2014-01-15 10:49:46 PST

Comment on attachment 221267 [details] Patch 2 r=me

Mihnea Ovidenie

Comment 8 2014-01-15 22:53:32 PST

Created attachment 221335 [details] Patch for landing

WebKit Commit Bot

Comment 9 2014-01-15 23:29:37 PST

Comment on attachment 221335 [details] Patch for landing Clearing flags on attachment: 221335 Committed r162117: <http://trac.webkit.org/changeset/162117>

WebKit Commit Bot

Comment 10 2014-01-15 23:29:40 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.