Bug 130922

Summary: [CSS Blending] showLayerTree should dump layer's blend mode and isolation properties
Product: WebKit Reporter: Ion Rosca <rosca>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, esprehn+autocc, glenn, kondapallykalyan, mihnea, simon.fraser, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95614    
Attachments:
Description Flags
adding blending debug values
none
get blendMode from RenderLayer object
none
#ifdef and isolation->isolatesBlending none

Ion Rosca
Reported 2014-03-28 17:20:05 PDT
showLayerTree does not provide information regarding blending. It would be useful to add blendMode property and layer's isolation status (if it isolates some blending descendants).
Attachments
adding blending debug values (18.96 KB, patch)
2014-03-28 17:30 PDT, Ion Rosca 		no flags
DetailsFormatted DiffDiff
get blendMode from RenderLayer object (18.94 KB, patch)
2014-03-31 02:26 PDT, Ion Rosca 		no flags
DetailsFormatted DiffDiff
#ifdef and isolation->isolatesBlending (19.02 KB, patch)
2014-03-31 10:34 PDT, Ion Rosca 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ion Rosca
Comment 1 2014-03-28 17:30:54 PDT
Created attachment 228100 [details] adding blending debug values
Ion Rosca
Comment 2 2014-03-31 02:26:14 PDT
Created attachment 228159 [details] get blendMode from RenderLayer object
Mihnea Ovidenie
Comment 3 2014-03-31 08:14:24 PDT
Comment on attachment 228159 [details] get blendMode from RenderLayer object View in context: https://bugs.webkit.org/attachment.cgi?id=228159&action=review You have to get Simon's or Dean's review on this but i will give you my opinion, hopefully it is valuable. > Source/WebCore/rendering/RenderLayer.h:789 > + BlendMode blendMode() const I think we should wrap everything in CSS_COMPOSITING unless it is really important to have functions that work also when CSS_COMPOSITING is not enabled. > Source/WebCore/rendering/RenderTreeAsText.cpp:631 > + if (l.hasBlendMode()) I would use ENABLE(CSS_COMPOSITING) to guard this code. In addition to that, i would simply output "isolatesBlending" instead of "isolation" when a layer does this.
Ion Rosca
Comment 4 2014-03-31 10:34:39 PDT
Created attachment 228183 [details] #ifdef and isolation->isolatesBlending
WebKit Commit Bot
Comment 5 2014-03-31 14:07:14 PDT
Comment on attachment 228183 [details] #ifdef and isolation->isolatesBlending Clearing flags on attachment: 228183 Committed r166525: <http://trac.webkit.org/changeset/166525>
WebKit Commit Bot
Comment 6 2014-03-31 14:07:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.