Bug 131211

Summary: [CSSRegions] Region's behaviour not updated when becoming valid from invalid
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Patch
none
Patch for landing none

Mihnea Ovidenie
Reported 2014-04-03 23:02:50 PDT
When a region becomes valid again from invalid - it was part of a dependency cycle but the dependency cycle was broken - it needs to behave like a valid region - autoheight, region styling.
Attachments
Patch (13.27 KB, patch)
2014-04-03 23:41 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.78 KB, patch)
2014-04-04 07:29 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2014-04-03 23:41:02 PDT
Created attachment 228579 [details] Patch
Andrei Bucur
Comment 2 2014-04-04 00:19:07 PDT
Comment on attachment 228579 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228579&action=review r=me > Source/WebCore/rendering/RenderNamedFlowFragment.cpp:80 > // If the region is not attached to any thread, there is no need to check You should consider removing this comment. > Source/WebCore/rendering/RenderNamedFlowFragment.cpp:-511 > - if (documentBeingDestroyed() || !m_flowThread) Let's make a patch that removes the m_flowThread nullification as well. The isValid() check should be enough.
Mihnea Ovidenie
Comment 3 2014-04-04 07:29:00 PDT
Created attachment 228590 [details] Patch for landing
WebKit Commit Bot
Comment 4 2014-04-04 08:06:09 PDT
Comment on attachment 228590 [details] Patch for landing Clearing flags on attachment: 228590 Committed r166781: <http://trac.webkit.org/changeset/166781>
WebKit Commit Bot
Comment 5 2014-04-04 08:06:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.