Bug 142182

Summary: Baseline JIT op_new_func_exp shouldn't check for undefined scope
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED INVALID    
Severity: Normal CC: buildbot, ggaren, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 141174    
Attachments:
Description Flags
the patch
msaboff: review+, buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-mavericks none

Filip Pizlo
Reported 2015-03-02 11:20:04 PST
We don't do undefined scopes anymore.
Attachments
the patch (2.03 KB, patch)
2015-03-02 11:21 PST, Filip Pizlo 		msaboff: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-mavericks (594.05 KB, application/zip)
2015-03-02 11:40 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-03-02 11:21:45 PST
Created attachment 247683 [details] the patch
Michael Saboff
Comment 2 2015-03-02 11:23:52 PST
Comment on attachment 247683 [details] the patch r=me
Build Bot
Comment 3 2015-03-02 11:40:38 PST
Comment on attachment 247683 [details] the patch Attachment 247683 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5414865313202176 New failing tests: js/regress-140033.html
Build Bot
Comment 4 2015-03-02 11:40:41 PST
Created attachment 247686 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Filip Pizlo
Comment 5 2015-03-02 11:41:55 PST
Oh, this is actually still needed due to OSR exit.
Geoffrey Garen
Comment 6 2015-03-02 12:49:42 PST
This requirement of OSR exit is pretty surprising. :(
Filip Pizlo
Comment 7 2015-03-02 14:39:08 PST
(In reply to comment #6) > This requirement of OSR exit is pretty surprising. :( I like that the baseline JIT is sort of enslaved to the whims of OSR exit; this tends to be easier to reason about than exit-time rematerialization. We should do a better job of documenting this contract, though.
Note You need to log in before you can comment on or make changes to this bug.