Bug 155166

Summary:

Implement rel=noopener

Product:

WebKit

Reporter:

Mathias Bynens <mathias>

Component:

DOM

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, aestes, alwillis, ap, bfulgham, cdumez, commit-queue, darin, dbates, esprehn+autocc, gyuyoung.kim, japhet, koivisto, mathias, m.goleb+bugzilla, mkwst, sam, teppeis, webkit-bug-importer, wilander, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

http://code.google.com/p/chromium/issues/detail?id=168988
https://bugs.webkit.org/show_bug.cgi?id=163960

Attachments:

Description	Flags
Patch	none
Patch	none

Mathias Bynens

Reported 2016-03-08 02:42:10 PST

Spec: https://html.spec.whatwg.org/multipage/semantics.html#link-type-noopener Discussion/background: https://github.com/whatwg/html/pull/290 Explainer: https://mathiasbynens.github.io/rel-noopener/

Attachments
Patch (18.48 KB, patch) 2016-10-24 18:17 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (18.42 KB, patch) 2016-10-25 11:11 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mike West

Comment 1 2016-03-16 05:20:59 PDT

CCing potentially interested folks.

Radar WebKit Bug Importer

Comment 2 2016-03-16 09:38:03 PDT

<rdar://problem/25193787>

Andy Estes

Comment 3 2016-10-24 18:17:22 PDT

Created attachment 292690 [details] Patch

Andy Estes

Comment 4 2016-10-24 18:23:14 PDT

We should also support the "noopener" feature for window.open(). I'll file a separate bug about that.

Andy Estes

Comment 5 2016-10-24 19:06:10 PDT

Comment on attachment 292690 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292690&action=review > Source/WebCore/html/HTMLAnchorElement.cpp:-252 > - // Update HTMLAnchorElement::relList() if more rel attributes values are supported. I didn't mean to remove this comment. I'll restore it before landing.

Brent Fulgham

Comment 6 2016-10-24 20:10:56 PDT

Comment on attachment 292690 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292690&action=review r=me > Source/WebCore/html/HTMLAnchorElement.h:-55 > -// RelationUp = 0x00020000, Are all of these implemented now? :-)

Andy Estes

Comment 7 2016-10-24 20:13:17 PDT

(In reply to comment #6) > Comment on attachment 292690 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=292690&action=review > > r=me > > > Source/WebCore/html/HTMLAnchorElement.h:-55 > > -// RelationUp = 0x00020000, > > Are all of these implemented now? :-) No, but there's no point in leaving the list of unimplemented values in a comment. The HTML spec is the right place for that list.

Andy Estes

Comment 8 2016-10-24 20:13:54 PDT

And thanks for the review :)

Andy Estes

Comment 9 2016-10-25 11:11:06 PDT

Created attachment 292786 [details] Patch

WebKit Commit Bot

Comment 10 2016-10-25 11:58:44 PDT

The commit-queue encountered the following flaky tests while processing attachment 292786 [details]: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 11 2016-10-25 11:58:49 PDT

The commit-queue encountered the following flaky tests while processing attachment 292786 [details]: The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 12 2016-10-25 13:20:26 PDT

Comment on attachment 292786 [details] Patch Clearing flags on attachment: 292786 Committed r207840: <http://trac.webkit.org/changeset/207840>

WebKit Commit Bot

Comment 13 2016-10-25 13:20:32 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.