Bug 155788

Summary: [css-grid] Remove unneeded lines in offsetAndBreadthForPositionedChild()
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Layout and RenderingAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jfernandez, kondapallykalyan, rego, simon.fraser, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch
none
Patch for landing none

Manuel Rego Casasnovas
Reported 2016-03-23 04:42:08 PDT
[css-grid] Remove unneeded lines in offsetAndBreadthForPositionedChild()
Attachments
Patch (2.11 KB, patch)
2016-03-23 04:44 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.12 KB, patch)
2016-03-28 03:34 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2016-03-23 04:44:19 PDT
Created attachment 274744 [details] Patch
Sergio Villar Senin
Comment 2 2016-03-28 02:27:52 PDT
Comment on attachment 274744 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274744&action=review > Source/WebCore/rendering/RenderGrid.cpp:1520 > + LayoutUnit start = startIsAuto ? LayoutUnit() : isRowAxis ? m_columnPositions[startLine] : m_rowPositions[startLine]; Mind adding parens here too. Otherwise it's very difficult to read.
Manuel Rego Casasnovas
Comment 3 2016-03-28 03:34:28 PDT
Created attachment 275020 [details] Patch for landing
Manuel Rego Casasnovas
Comment 4 2016-03-28 03:35:06 PDT
Thanks for the review. (In reply to comment #2) > Comment on attachment 274744 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=274744&action=review > > > Source/WebCore/rendering/RenderGrid.cpp:1520 > > + LayoutUnit start = startIsAuto ? LayoutUnit() : isRowAxis ? m_columnPositions[startLine] : m_rowPositions[startLine]; > > Mind adding parens here too. Otherwise it's very difficult to read. Done.
WebKit Commit Bot
Comment 5 2016-03-28 04:22:46 PDT
Comment on attachment 275020 [details] Patch for landing Clearing flags on attachment: 275020 Committed r198732: <http://trac.webkit.org/changeset/198732>
WebKit Commit Bot
Comment 6 2016-03-28 04:22:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.