Bug 161136

Summary: More cleanup for the mpadded implementation
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbarton, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 155879    
Attachments:
Description Flags
Patch none

Frédéric Wang (:fredw)
Reported 2016-08-24 06:31:47 PDT
It seems that the m_ascent member is not really needed as the ascent can be easily calculated in firstLineBaseLine() after some adjustment with how the attribute values are resolved. I was not able to find a testcase that shows how it improves dynamic update. Actually, it seems that we no longer need to override styleDidChange and updateFromElement so I'll remove them in that bug too.
Attachments
Patch (11.53 KB, patch)
2016-08-24 06:47 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2016-08-24 06:47:20 PDT
Created attachment 286850 [details] Patch
WebKit Commit Bot
Comment 2 2016-08-28 01:27:55 PDT
Comment on attachment 286850 [details] Patch Clearing flags on attachment: 286850 Committed r205098: <http://trac.webkit.org/changeset/205098>
WebKit Commit Bot
Comment 3 2016-08-28 01:28:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.