Bug 167301

Summary: Remove allowWindowOpenWithoutUserGesture setting
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit Misc.Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, wilander
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-01-22 22:55:24 PST
This Setting, used only by Mac WebKit1 is a duplicate of the javaScriptCanOpenWindowsAutomatically setting. Comments on bug 159049 hinted at this, and it remains the case.
Attachments
[PATCH] Proposed Fix (4.46 KB, patch)
2017-01-22 22:58 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (4.34 KB, patch)
2017-01-22 23:16 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-01-22 22:58:06 PST
Created attachment 299503 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2017-01-22 23:11:06 PST
Comment on attachment 299503 [details] [PATCH] Proposed Fix My build doesn't like this. Must have missed something...
Joseph Pecoraro
Comment 3 2017-01-22 23:16:59 PST
Created attachment 299504 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 4 2017-01-23 00:00:16 PST
The commit-queue encountered the following flaky tests while processing attachment 299504 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2017-01-23 01:56:14 PST
Comment on attachment 299504 [details] [PATCH] Proposed Fix Clearing flags on attachment: 299504 Committed r211036: <http://trac.webkit.org/changeset/211036>
WebKit Commit Bot
Comment 6 2017-01-23 01:56:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.