Bug 169195

Summary: Unprefix -webkit-min-content, -webkit-max-content and -webkit-fit-content
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: CSSAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: 50167214, commit-queue, darin, dino, hyatt, jfernandez, rego, simon.fraser, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/chromium/issues/detail?id=245157
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Manuel Rego Casasnovas
Reported 2017-03-06 04:50:32 PST
It'd be really nice to unprefix these properties for CSS Grid Layout. This would be similar to what we're already doing for "fit-content" which is unprefix for Grid Layout, but prefixed if you use it in "width" or "height" properties.
Attachments
Patch (238.69 KB, patch)
2017-03-07 01:24 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (239.73 KB, patch)
2017-03-07 02:13 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch for landing (239.54 KB, patch)
2017-03-13 03:08 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2017-03-07 01:11:20 PST
After checking the status of things I believe we should unprefix min-content, max-content and fit-content for all the elements and not only Grid Layout. As we're now shipping Grid Layout, having to mix prefixes with no prefixes in declarations is really confusing: grid-tempalte-columns: -webkit-min-content fit-content(500px) -webkit-max-content; So my proposal would be to follow the path started by Blink and unprefix those properties, and wait until for the CSS WG resolution regarding -webkit-fill-available. That would move us to the same status than Blink. See https://bugs.chromium.org/p/chromium/issues/detail?id=245157 for more information. There were a previous discussion on webkit-dev about this, and the only comment was in favor of doing it: https://lists.webkit.org/pipermail/webkit-dev/2015-August/027604.html Also there's a FIXME on the new parser about this: // FIXME-NEWPARSER: Drop the prefix on min-content, max-content and fit-content. Note that we should keep support for the prefixed properties, as people have been using them for a long time. They could eventually be deprecated and removed in the future.
Manuel Rego Casasnovas
Comment 2 2017-03-07 01:24:06 PST
Created attachment 303637 [details] Patch
Manuel Rego Casasnovas
Comment 3 2017-03-07 02:13:38 PST
Created attachment 303638 [details] Patch Update results for css3/flexbox/orthogonal-writing-modes-and-intrinsic-sizing.html that was already using the unprefixed version.
Simon Fraser (smfr)
Comment 4 2017-03-07 08:31:21 PST
Please also update CSSProperties.json.
Manuel Rego Casasnovas
Comment 5 2017-03-07 12:14:14 PST
(In reply to comment #4) > Please also update CSSProperties.json. These are values for width and height properties (also min|max-width|height), so not new properties but new keywords. I don't find the old prefixed versions on CSSProperties.json, what should I add there?
Sergio Villar Senin
Comment 6 2017-03-13 02:30:00 PDT
Comment on attachment 303638 [details] Patch Check the error reported by the bindings EWS
Manuel Rego Casasnovas
Comment 7 2017-03-13 03:08:47 PDT
Created attachment 304248 [details] Patch for landing
WebKit Commit Bot
Comment 8 2017-03-13 04:44:50 PDT
Comment on attachment 304248 [details] Patch for landing Clearing flags on attachment: 304248 Committed r213831: <http://trac.webkit.org/changeset/213831>
WebKit Commit Bot
Comment 9 2017-03-13 04:44:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.