Bug 176177

Summary: WSL parser should pass the token as the origin to the AST
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebGPUAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: keith_miller, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
the patch
none
the patch keith_miller: review+

Filip Pizlo
Reported 2017-08-31 12:42:41 PDT
Patch forthcoming.
Attachments
the patch (13.90 KB, patch)
2017-08-31 12:44 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (13.53 KB, patch)
2017-08-31 12:46 PDT, Filip Pizlo 		keith_miller: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-08-31 12:44:57 PDT
Created attachment 319503 [details] the patch
Filip Pizlo
Comment 2 2017-08-31 12:46:26 PDT
Created attachment 319504 [details] the patch
Keith Miller
Comment 3 2017-08-31 12:48:45 PDT
Comment on attachment 319504 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=319504&action=review r=me with nit. > Tools/WebGPUShadingLanguageRI/Test.js:67 > + () => prepare("<test>", 0, "int foo(int x) { return x + y; }"), Nit: Seems like you might want to make a wrapper for prepare in this file. I expect you'll be calling it a lot...
Filip Pizlo
Comment 4 2017-08-31 12:52:19 PDT
Landed in https://trac.webkit.org/changeset/221436/webkit
Radar WebKit Bug Importer
Comment 5 2017-09-27 12:59:01 PDT
<rdar://problem/34694419>
Myles C. Maxfield
Comment 6 2018-10-13 20:06:08 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/209
Note You need to log in before you can comment on or make changes to this bug.