Bug 179553

Summary: [Windows] Fix Python error for subprocess.popen with close_fds
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: Tools / TestsAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, basuke, bfulgham, buildbot, commit-queue, don.olmstead, fujii.hironori, glenn, lforschler, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 179216    
Attachments:
Description Flags
fix none

Basuke Suzuki
Reported 2017-11-10 15:11:26 PST
When running test-webkitpy, there're many failure caused by following error: > ValueError: close_fds is not supported on Windows platforms if you redirect stdin/stdout/stderr
Attachments
fix (2.56 KB, patch)
2017-11-13 14:10 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2017-11-10 15:11:49 PST
On Windows native command prompt (not Cygwin)
Basuke Suzuki
Comment 2 2017-11-13 14:10:35 PST
Created attachment 326798 [details] fix
Basuke Suzuki
Comment 3 2017-11-13 14:16:28 PST
I chose just passing False (don't close fds) because we cannot move forward with this flag True on Windows w/o Cygwin. We will figured out the actual issue caused by passing False here later.
Per Arne Vollan
Comment 4 2017-11-13 15:56:16 PST
Comment on attachment 326798 [details] fix R=me.
WebKit Commit Bot
Comment 5 2017-11-13 16:55:45 PST
Comment on attachment 326798 [details] fix Clearing flags on attachment: 326798 Committed r224795: <https://trac.webkit.org/changeset/224795>
WebKit Commit Bot
Comment 6 2017-11-13 16:55:46 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-15 09:35:33 PST
<rdar://problem/35562026>
Note You need to log in before you can comment on or make changes to this bug.