Bug 192334

Summary:

CSS Properties and Values API should support animating registered custom properties without any references

Product:

WebKit

Reporter:

Justin Michaud <justin_michaud>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

REOPENED

Severity:

Normal

CC:

achristensen, bfulgham, bramus, ews-watchlist, graouts, rniwa, simon.fraser, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

192828

Bug Blocks:

192324

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews116 for mac-sierra	none
Archive of layout-test-results from ews203 for win-future	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	none

Justin Michaud

Reported 2018-12-03 14:56:41 PST

Properties that are not used in substitutions should be able to be transitioned. This blocks 192324.

Attachments
Patch (49.70 KB, patch) 2018-12-05 19:28 PST, Justin Michaud	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.50 MB, application/zip) 2018-12-05 20:38 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.69 MB, application/zip) 2018-12-05 21:04 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews116 for mac-sierra (2.25 MB, application/zip) 2018-12-05 21:29 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews203 for win-future (12.78 MB, application/zip) 2018-12-05 21:41 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.43 MB, application/zip) 2018-12-06 00:29 PST, EWS Watchlist	no flags	Details
Patch (61.98 KB, patch) 2018-12-10 22:34 PST, Justin Michaud	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Justin Michaud

Comment 1 2018-12-05 19:28:23 PST

Created attachment 356699 [details] Patch

EWS Watchlist

Comment 2 2018-12-05 19:31:13 PST Comment hidden (obsolete)

Attachment 356699 [details] did not pass style-queue: ERROR: Source/WebCore/animation/KeyframeEffect.cpp:1202: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Justin Michaud

Comment 3 2018-12-05 19:31:26 PST

This patch is not complete yet. In particular, I would like to have the wpt tests for css variables imported first, to make sure nothing breaks. Right now, I have debug assertions everywhere just to aid in debugging. WebAnimations as well as declarative animations are not implemented yet. I am uploading this to get some preliminary feedback while I import the wpt tests and fix those bugs.

Simon Fraser (smfr)

Comment 4 2018-12-05 19:41:19 PST

Comment on attachment 356699 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356699&action=review > Source/WebCore/animation/AnimationTimeline.cpp:380 > +void AnimationTimeline::updateCustomPropertyCSSTransitionsForElement(Element& element, const RenderStyle& currentStyle, const RenderStyle& afterChangeStyle) Holy shit. > Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1874 > + return (!aValue && !bValue) || (aValue && bValue && *aValue == *bValue); We have a thing for this: arePointingToEqualData()

EWS Watchlist

Comment 5 2018-12-05 20:38:03 PST Comment hidden (obsolete)

Comment on attachment 356699 [details] Patch Attachment 356699 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10287476 New failing tests: transitions/transitions-parsing.html legacy-animation-engine/transitions/transitions-parsing.html

EWS Watchlist

Comment 6 2018-12-05 20:38:05 PST Comment hidden (obsolete)

Created attachment 356703 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-12-05 21:04:38 PST Comment hidden (obsolete)

Comment on attachment 356699 [details] Patch Attachment 356699 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10287603 New failing tests: transitions/transitions-parsing.html imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-cycles.html legacy-animation-engine/transitions/transitions-parsing.html

EWS Watchlist

Comment 8 2018-12-05 21:04:40 PST Comment hidden (obsolete)

Created attachment 356705 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 9 2018-12-05 21:29:24 PST Comment hidden (obsolete)

Comment on attachment 356699 [details] Patch Attachment 356699 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10287568 New failing tests: transitions/transition-unknown-property-ignore.html legacy-animation-engine/transitions/transition-unknown-property-ignore.html transitions/transitions-parsing.html legacy-animation-engine/transitions/transitions-parsing.html

EWS Watchlist

Comment 10 2018-12-05 21:29:25 PST Comment hidden (obsolete)

Created attachment 356707 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 11 2018-12-05 21:41:26 PST Comment hidden (obsolete)

Comment on attachment 356699 [details] Patch Attachment 356699 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/10287817 New failing tests: transitions/transitions-parsing.html

EWS Watchlist

Comment 12 2018-12-05 21:41:38 PST Comment hidden (obsolete)

Created attachment 356711 [details] Archive of layout-test-results from ews203 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews203 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

EWS Watchlist

Comment 13 2018-12-06 00:29:47 PST Comment hidden (obsolete)

Comment on attachment 356699 [details] Patch Attachment 356699 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10289191 New failing tests: transitions/transitions-parsing.html imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-cycles.html legacy-animation-engine/transitions/transitions-parsing.html

EWS Watchlist

Comment 14 2018-12-06 00:29:49 PST Comment hidden (obsolete)

Created attachment 356720 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Justin Michaud

Comment 15 2018-12-10 22:34:16 PST

Created attachment 357034 [details] Patch

Justin Michaud

Comment 16 2018-12-10 22:35:03 PST

This is beautiful.

Alex Christensen

Comment 17 2021-11-01 12:44:38 PDT

Comment on attachment 357034 [details] Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.

Justin Michaud

Comment 18 2024-04-08 13:37:21 PDT

Closing old bugs assigned to me

Justin Michaud

Comment 19 2024-04-08 13:37:40 PDT

Closing old bugs assigned to me

Simon Fraser (smfr)

Comment 20 2024-04-08 15:13:28 PDT

Reopening.

Note You need to log in before you can comment on or make changes to this bug.