Bug 192721

Summary: Bindings generator should support Conditional= along with CachedAttribute
Product: WebKit Reporter: Justin Michaud <justin_michaud>
Component: BindingsAssignee: Justin Michaud <justin_michaud>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, ews-watchlist, kondapallykalyan, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 192671    
Attachments:
Description Flags
Patch
none
Patch none

Justin Michaud
Reported 2018-12-14 16:01:02 PST
Bindings generator should support Conditional= along with CachedAttribute
Attachments
Patch (8.20 KB, patch)
2018-12-14 16:19 PST, Justin Michaud 		no flags
DetailsFormatted DiffDiff
Patch (8.20 KB, patch)
2018-12-17 18:38 PST, Justin Michaud 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Justin Michaud
Comment 1 2018-12-14 16:19:19 PST
Created attachment 357353 [details] Patch
Ryosuke Niwa
Comment 2 2018-12-17 18:26:27 PST
Comment on attachment 357353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357353&action=review > Source/WebCore/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). This line should appear after the URL but before the long description.
Justin Michaud
Comment 3 2018-12-17 18:38:45 PST
Created attachment 357513 [details] Patch
WebKit Commit Bot
Comment 4 2018-12-17 20:18:06 PST
Comment on attachment 357513 [details] Patch Clearing flags on attachment: 357513 Committed r239316: <https://trac.webkit.org/changeset/239316>
WebKit Commit Bot
Comment 5 2018-12-17 20:18:07 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-12-17 20:19:26 PST
<rdar://problem/46799990>
Note You need to log in before you can comment on or make changes to this bug.