Bug 194080

Summary: Generalize ScrollingTreeScrollingNodeDelegate for use in macOS too, add a macOS subclass for frame/overflow scrolling
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, ews-watchlist, fred.wang, jamesr, koivisto, luiz, simon.fraser, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 172917    
Bug Blocks:    
Attachments:
Description Flags
Patch
koivisto: review+
Patch none

Simon Fraser (smfr)
Reported 2019-01-30 22:33:02 PST
Generalize ScrollingTreeScrollingNodeDelegate for use in macOS too, add a macOS subclass for frame/overflow scrolling
Attachments
Patch (57.95 KB, patch)
2019-01-30 22:37 PST, Simon Fraser (smfr) 		koivisto: review+
DetailsFormatted DiffDiff
Patch (57.95 KB, patch)
2019-01-31 08:32 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2019-01-30 22:37:32 PST
Created attachment 360693 [details] Patch
Simon Fraser (smfr)
Comment 2 2019-01-30 22:38:05 PST
Probably won't build without the patch from bug 172917.
Antti Koivisto
Comment 3 2019-01-30 23:28:23 PST
Comment on attachment 360693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360693&action=review > Source/WebCore/ChangeLog:12 > + Add a macOS subclass, ScrollingTreeFrameScrollingNodeMac, which takes over the basic scrolling, rubber-banding > + and scroll snapping functionality from ScrollingTreeFrameScrollingNodeMac. The delegate owns the ScrollController and ScrollingTreeFrameScrollingNodeMac is probably not taking over from itself
Simon Fraser (smfr)
Comment 4 2019-01-31 08:32:54 PST
Created attachment 360729 [details] Patch
Simon Fraser (smfr)
Comment 5 2019-01-31 15:27:10 PST
https://trac.webkit.org/r240825
Radar WebKit Bug Importer
Comment 6 2019-01-31 15:28:28 PST
<rdar://problem/47718823>
Note You need to log in before you can comment on or make changes to this bug.