Bug 194409

Summary: [Web GPU] GPUDevice::createTexture implementation prototype
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: WebGPUAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, graouts, kondapallykalyan, mmaxfield, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Justin Fan
Reported 2019-02-07 13:03:19 PST
[Web GPU] GPUDevice::createTexture implementation prototype
Attachments
Patch (29.89 KB, patch)
2019-02-07 13:20 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch (29.95 KB, patch)
2019-02-07 13:40 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch (30.01 KB, patch)
2019-02-07 14:10 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.03 KB, patch)
2019-02-07 17:32 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-02-07 13:03:59 PST
<rdar://problem/47894312>
Justin Fan
Comment 2 2019-02-07 13:20:14 PST
Created attachment 361432 [details] Patch
Justin Fan
Comment 3 2019-02-07 13:40:17 PST
Created attachment 361438 [details] Patch
Justin Fan
Comment 4 2019-02-07 14:10:38 PST
Created attachment 361441 [details] Patch
Dean Jackson
Comment 5 2019-02-07 16:38:29 PST
Comment on attachment 361441 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361441&action=review > Source/WebCore/platform/graphics/gpu/cocoa/GPUTextureMetal.mm:66 > + if (usage & MTLTextureUsageShaderWrite) I'm not sure if we should be testing for the MTL form or the GPUTextureUsage::Storage flag. I think the latter makes more sense. > Source/WebCore/platform/graphics/gpu/cocoa/GPUTextureMetal.mm:75 > + return usage; Should it be an error (nullopt) to return unknown? > Source/WebCore/platform/graphics/gpu/cocoa/GPUTextureMetal.mm:110 > + auto usage = mtlTextureUsageForGPUTextureUsageFlags(descriptor.usage); > + if (!usage) { Yeah, so here.... if we're usage type unknown, should we error? > Source/WebCore/platform/graphics/gpu/cocoa/GPUTextureMetal.mm:111 > + LOG(WebGPU, "%s: Invalid GPUTextureUsageFlags!"); You forgot functionName. Surprised it compiled.
Justin Fan
Comment 6 2019-02-07 17:32:28 PST
Created attachment 361474 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-02-07 18:00:55 PST
The commit-queue encountered the following flaky tests while processing attachment 361474 [details]: media/modern-media-controls/compact-media-controls/compact-media-controls-constructor.html bug 193587 (author: graouts@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2019-02-07 18:01:45 PST
Comment on attachment 361474 [details] Patch for landing Clearing flags on attachment: 361474 Committed r241181: <https://trac.webkit.org/changeset/241181>
WebKit Commit Bot
Comment 9 2019-02-07 18:01:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.