Bug 196557

Summary:

Update AutoFill field icons to be SVG instead of PNG images

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

WebCore Misc.

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, ews-watchlist, rniwa, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-cq-03 for mac-highsierra	none
Archive of layout-test-results from ews104 for mac-highsierra-wk2	none
Archive of layout-test-results from ews103 for mac-highsierra	none
Archive of layout-test-results from ews114 for mac-highsierra	none
Archive of layout-test-results from ews205 for win-future	none
Patch	none
Archive of layout-test-results from ews102 for mac-highsierra	none
Archive of layout-test-results from ews105 for mac-highsierra-wk2	none
Patch	none

Timothy Hatcher

Reported 2019-04-03 13:31:17 PDT

These should be vector. <rdar://problem/48292514>

Attachments
Patch (12.06 KB, patch) 2019-04-03 13:32 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-cq-03 for mac-highsierra (2.68 MB, application/zip) 2019-04-03 14:28 PDT, WebKit Commit Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (3.26 MB, application/zip) 2019-04-03 14:30 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews103 for mac-highsierra (2.44 MB, application/zip) 2019-04-03 14:35 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-highsierra (2.30 MB, application/zip) 2019-04-03 15:28 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews205 for win-future (12.87 MB, application/zip) 2019-04-03 15:40 PDT, EWS Watchlist	no flags	Details
Patch (32.36 KB, patch) 2019-04-03 18:49 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-highsierra (2.49 MB, application/zip) 2019-04-03 19:52 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (3.21 MB, application/zip) 2019-04-03 20:03 PDT, EWS Watchlist	no flags	Details
Patch (21.17 KB, patch) 2019-04-03 20:09 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2019-04-03 13:32:32 PDT Comment hidden (obsolete)

Created attachment 366635 [details] Patch

WebKit Commit Bot

Comment 2 2019-04-03 14:14:41 PDT Comment hidden (obsolete)

The commit-queue encountered the following flaky tests while processing attachment 366635 [details]: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 3 2019-04-03 14:14:42 PDT Comment hidden (obsolete)

The commit-queue encountered the following flaky tests while processing attachment 366635 [details]: The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 4 2019-04-03 14:28:10 PDT Comment hidden (obsolete)

Comment on attachment 366635 [details] Patch Rejecting attachment 366635 [details] from commit-queue. New failing tests: fast/forms/auto-fill-button/input-auto-fill-button.html Full output: https://webkit-queues.webkit.org/results/11755289

WebKit Commit Bot

Comment 5 2019-04-03 14:28:12 PDT Comment hidden (obsolete)

Created attachment 366643 [details] Archive of layout-test-results from webkit-cq-03 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-03 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 6 2019-04-03 14:30:49 PDT Comment hidden (obsolete)

Comment on attachment 366635 [details] Patch Attachment 366635 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11755195 New failing tests: fast/forms/auto-fill-button/input-auto-fill-button.html

EWS Watchlist

Comment 7 2019-04-03 14:30:50 PDT Comment hidden (obsolete)

Created attachment 366644 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 8 2019-04-03 14:35:17 PDT Comment hidden (obsolete)

Comment on attachment 366635 [details] Patch Attachment 366635 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11755363 New failing tests: fast/forms/auto-fill-button/input-auto-fill-button.html

EWS Watchlist

Comment 9 2019-04-03 14:35:18 PDT Comment hidden (obsolete)

Created attachment 366645 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 10 2019-04-03 15:28:30 PDT Comment hidden (obsolete)

Comment on attachment 366635 [details] Patch Attachment 366635 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11755580 New failing tests: fast/forms/auto-fill-button/input-auto-fill-button.html

EWS Watchlist

Comment 11 2019-04-03 15:28:32 PDT Comment hidden (obsolete)

Created attachment 366656 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 12 2019-04-03 15:40:23 PDT Comment hidden (obsolete)

Comment on attachment 366635 [details] Patch Attachment 366635 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11755787 New failing tests: fast/forms/auto-fill-button/input-auto-fill-button.html

EWS Watchlist

Comment 13 2019-04-03 15:40:34 PDT Comment hidden (obsolete)

Created attachment 366659 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Timothy Hatcher

Comment 14 2019-04-03 18:49:36 PDT Comment hidden (obsolete)

Created attachment 366690 [details] Patch

EWS Watchlist

Comment 15 2019-04-03 19:52:25 PDT Comment hidden (obsolete)

Comment on attachment 366690 [details] Patch Attachment 366690 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11759694 New failing tests: fast/forms/auto-fill-button/input-contacts-auto-fill-button.html fast/forms/auto-fill-button/input-credit-card-auto-fill-button.html fast/forms/auto-fill-button/input-auto-fill-button.html

EWS Watchlist

Comment 16 2019-04-03 19:52:27 PDT Comment hidden (obsolete)

Created attachment 366696 [details] Archive of layout-test-results from ews102 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 17 2019-04-03 20:03:00 PDT Comment hidden (obsolete)

Comment on attachment 366690 [details] Patch Attachment 366690 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11759696 New failing tests: fast/forms/auto-fill-button/input-contacts-auto-fill-button.html fast/forms/auto-fill-button/input-credit-card-auto-fill-button.html fast/forms/auto-fill-button/input-auto-fill-button.html

EWS Watchlist

Comment 18 2019-04-03 20:03:02 PDT Comment hidden (obsolete)

Created attachment 366697 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Timothy Hatcher

Comment 19 2019-04-03 20:09:38 PDT

Created attachment 366699 [details] Patch

WebKit Commit Bot

Comment 20 2019-04-03 22:47:49 PDT

Comment on attachment 366699 [details] Patch Clearing flags on attachment: 366699 Committed r243859: <https://trac.webkit.org/changeset/243859>

WebKit Commit Bot

Comment 21 2019-04-03 22:47:51 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.