Bug 197805

Summary:

[WebAuthN] Make WebAuthN default on

Product:

WebKit

Reporter:

Jiewen Tan <jiewen_tan>

Component:

WebCore Misc.

Assignee:

Jiewen Tan <jiewen_tan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alex.gaynor, bfulgham, commit-queue, darin, ews-watchlist, jiewen_tan, kieun.shin, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

181943

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Archive of layout-test-results from ews117 for mac-highsierra	none
Patch	none

Jiewen Tan

Reported 2019-05-10 17:10:23 PDT

Make WebAuthN default on.

Attachments
Patch (2.49 KB, patch) 2019-05-10 17:16 PDT, Jiewen Tan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.08 MB, application/zip) 2019-05-10 18:25 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-highsierra (2.88 MB, application/zip) 2019-05-10 19:10 PDT, EWS Watchlist	no flags	Details
Patch (1.17 KB, patch) 2019-05-14 12:57 PDT, Jiewen Tan	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-05-10 17:12:40 PDT

<rdar://problem/50683699>

Jiewen Tan

Comment 2 2019-05-10 17:16:51 PDT

Created attachment 369624 [details] Patch

EWS Watchlist

Comment 3 2019-05-10 18:25:04 PDT Comment hidden (obsolete)

Comment on attachment 369624 [details] Patch Attachment 369624 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12158519 New failing tests: fast/dom/navigator-detached-no-crash.html

EWS Watchlist

Comment 4 2019-05-10 18:25:06 PDT Comment hidden (obsolete)

Created attachment 369631 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 5 2019-05-10 19:09:59 PDT Comment hidden (obsolete)

Comment on attachment 369624 [details] Patch Attachment 369624 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12158672 New failing tests: fast/dom/navigator-detached-no-crash.html

EWS Watchlist

Comment 6 2019-05-10 19:10:00 PDT Comment hidden (obsolete)

Created attachment 369634 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6

Darin Adler

Comment 7 2019-05-13 20:16:01 PDT

(In reply to Build Bot from comment #5) > fast/dom/navigator-detached-no-crash.html Need to rebase this test.

Jiewen Tan

Comment 8 2019-05-14 12:56:04 PDT

(In reply to Darin Adler from comment #7) > (In reply to Build Bot from comment #5) > > fast/dom/navigator-detached-no-crash.html > > Need to rebase this test. I shouldn't change Source/WebCore/page/RuntimeEnabledFeatures.h which will enable WebAuthentication in LegacyWebKit. Thanks!

Jiewen Tan

Comment 9 2019-05-14 12:57:18 PDT

Created attachment 369886 [details] Patch

WebKit Commit Bot

Comment 10 2019-05-15 11:01:23 PDT

Comment on attachment 369886 [details] Patch Clearing flags on attachment: 369886 Committed r245329: <https://trac.webkit.org/changeset/245329>

WebKit Commit Bot

Comment 11 2019-05-15 11:01:25 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.