Bug 199279

Summary: Move WebKitLegacy off of a couple AppKit ivars
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: WebKit Misc.Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, fred.wang, jbedard, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 199209    
Attachments:
Description Flags
Patch none

Timothy Hatcher
Reported 2019-06-27 11:20:37 PDT
We use _borderView on NSWindow and _subviews on NSView. There are alternatives now. <rdar://problem/34983438>
Attachments
Patch (5.61 KB, patch)
2019-06-27 12:03 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2019-06-27 12:03:41 PDT
Created attachment 373042 [details] Patch
WebKit Commit Bot
Comment 2 2019-06-27 14:11:19 PDT
Comment on attachment 373042 [details] Patch Clearing flags on attachment: 373042 Committed r246905: <https://trac.webkit.org/changeset/246905>
WebKit Commit Bot
Comment 3 2019-06-27 14:11:21 PDT
All reviewed patches have been landed. Closing bug.
Frédéric Wang (:fredw)
Comment 4 2019-07-11 03:41:29 PDT
Comment on attachment 373042 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373042&action=review > Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:237 > + ALLOW_DEPRECATED_DECLARATIONS_END @Timothy: These _subviews are causing macOS build failures with XCode 11.0 beta 3 and the public SDK (that seems to be the only build failure though). Any idea? I wonder why SUBVIEWS_IVAR_SPI is not set with Xcode beta (maybe because I'm using Mojave not Catalina?).
Timothy Hatcher
Comment 5 2019-07-11 10:56:11 PDT
(In reply to Frédéric Wang (:fredw) from comment #4) > Comment on attachment 373042 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373042&action=review > > > Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:237 > > + ALLOW_DEPRECATED_DECLARATIONS_END > > @Timothy: These _subviews are causing macOS build failures with XCode 11.0 > beta 3 and the public SDK (that seems to be the only build failure though). > Any idea? I wonder why SUBVIEWS_IVAR_SPI is not set with Xcode beta (maybe > because I'm using Mojave not Catalina?). The SPI is only on Catalina. But it sounds like the SDK removed the ivars still…
Note You need to log in before you can comment on or make changes to this bug.