Bug 199794

Summary:

Add runtime flag for lazy image loading

Product:

WebKit

Reporter:

Rob Buis <rbuis>

Component:

Images

Assignee:

Rob Buis <rbuis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, darin, esprehn+autocc, ews-watchlist, fred.wang, gyuyoung.kim, jonlee, kondapallykalyan, sabouhallawa, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

196698

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Rob Buis

Reported 2019-07-15 01:27:19 PDT

Add runtime flag for lazy image loading.

Attachments
Patch (16.77 KB, patch) 2019-07-15 01:33 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (17.48 KB, patch) 2019-07-15 02:36 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (17.56 KB, patch) 2019-08-02 03:25 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (21.17 KB, patch) 2019-08-05 01:33 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (21.22 KB, patch) 2019-08-08 05:27 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (13.43 KB, patch) 2019-09-05 23:50 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2019-07-15 01:33:46 PDT

Created attachment 374107 [details] Patch

Rob Buis

Comment 2 2019-07-15 02:36:46 PDT

Created attachment 374108 [details] Patch

Rob Buis

Comment 3 2019-08-02 03:25:57 PDT

Created attachment 375406 [details] Patch

Darin Adler

Comment 4 2019-08-04 18:22:18 PDT

Comment on attachment 375406 [details] Patch OK. Wow this sure is a long way from "just add it to a list in one place". The WebKitLegacy part is particularly huge and ugly. Ironic because it’s not used by Safari. I was going to say review+, but wait, where is the part that makes this work in WebKitTestRunner for modern WebKit?

Rob Buis

Comment 5 2019-08-05 01:33:40 PDT

Created attachment 375526 [details] Patch

Rob Buis

Comment 6 2019-08-05 08:29:04 PDT

(In reply to Darin Adler from comment #4) > Comment on attachment 375406 [details] > Patch > > OK. Wow this sure is a long way from "just add it to a list in one place". > The WebKitLegacy part is particularly huge and ugly. Ironic because it’s not > used by Safari. It is a lot of work and easy to miss things. At least having dealt with it in the past, it is a little easier now. > I was going to say review+, but wait, where is the part that makes this work > in WebKitTestRunner for modern WebKit? Good catch, I added the TestOption in WebKitTestRunner.

Rob Buis

Comment 7 2019-08-08 05:27:25 PDT

Created attachment 375796 [details] Patch

WebKit Commit Bot

Comment 8 2019-08-08 07:55:27 PDT

Comment on attachment 375796 [details] Patch Clearing flags on attachment: 375796 Committed r248409: <https://trac.webkit.org/changeset/248409>

WebKit Commit Bot

Comment 9 2019-08-08 07:55:29 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 10 2019-08-08 07:56:18 PDT

<rdar://problem/54079915>