Bug 201083

Summary:

Regression(r248533) Assertion hit in isMainThread() for some clients using WTF because the main thread is not initialized

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Template Framework

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, benjamin, cmarcelo, commit-queue, dbates, ews-watchlist, fujii.hironori, ggaren, jeffm, rniwa, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=201947

Bug Depends on:

Bug Blocks:

200507

Attachments:

Description	Flags
Patch	none

Chris Dumez

Reported 2019-08-23 12:09:14 PDT

An assertion is hit in isMainThread() for some clients using WTF because the main thread is not initialized, since r248533.

Attachments
Patch (4.29 KB, patch) 2019-08-23 12:11 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2019-08-23 12:10:30 PDT

Clients can work around this by calling WTF::initializeMainThread() before using WTF but it seems unfortunate to force them to do so. I propose we disable the assertion until the main thread is initialized.

Chris Dumez

Comment 2 2019-08-23 12:11:53 PDT

Created attachment 377148 [details] Patch

Chris Dumez

Comment 3 2019-08-23 12:14:40 PDT

See <rdar://problem/54616639> & <rdar://problem/54323901>.

WebKit Commit Bot

Comment 4 2019-08-23 13:31:15 PDT

Comment on attachment 377148 [details] Patch Clearing flags on attachment: 377148 Committed r249064: <https://trac.webkit.org/changeset/249064>

WebKit Commit Bot

Comment 5 2019-08-23 13:31:16 PDT

All reviewed patches have been landed. Closing bug.