Bug 201109

Summary: Add a script to update ANGLE
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: ANGLEAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dino, ews-watchlist, graouts, kbr, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 198948    
Attachments:
Description Flags
Patch none

James Darpinian
Reported 2019-08-23 17:34:05 PDT
Add a script to update ANGLE
Attachments
Patch (2.66 KB, patch)
2019-08-23 17:35 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2019-08-23 17:35:57 PDT
Created attachment 377186 [details] Patch
James Darpinian
Comment 2 2019-08-23 17:37:19 PDT
*** Bug 201013 has been marked as a duplicate of this bug. ***
EWS Watchlist
Comment 3 2019-08-23 17:38:13 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
James Darpinian
Comment 4 2019-08-23 17:40:04 PDT
This is no longer moving ANGLE to a different directory, it's just a single script file now.
Alex Christensen
Comment 5 2019-08-26 10:03:34 PDT
Comment on attachment 377186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377186&action=review > Source/ThirdParty/ANGLE/update-angle.sh:51 > +if ! git am changes.diff; then This won't work for anyone using svn, but that's probably no big deal.
WebKit Commit Bot
Comment 6 2019-08-26 10:36:35 PDT
Comment on attachment 377186 [details] Patch Clearing flags on attachment: 377186 Committed r249103: <https://trac.webkit.org/changeset/249103>
WebKit Commit Bot
Comment 7 2019-08-26 10:36:36 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-08-26 10:38:39 PDT
<rdar://problem/54712643>
James Darpinian
Comment 9 2019-08-26 10:41:41 PDT
Thanks! I believe the script should work for svn users as long as they have git installed. The script runs git in a clone of the ANGLE git repo, not the main WebKit repo.
Note You need to log in before you can comment on or make changes to this bug.