Bug 201150

Summary: Web Inspector: remove "extra domains" concept now that domains can be added based on the debuggable type
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 200384, 203300    
Bug Blocks: 213632    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2019-08-26 14:05:26 PDT
.
Attachments
Patch (27.43 KB, patch)
2020-06-25 17:38 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (40.21 KB, patch)
2020-06-25 17:42 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-10-23 11:07:56 PDT
<rdar://problem/56545911>
Devin Rousso
Comment 2 2020-05-22 15:42:53 PDT
We also should introduce an `InspectorBackend.finalize()` (or something like that) so that `InspectorBackend` can release the domains/commands/events that aren't actually being used. It might be worth adding `targetTypes` support to types too.
Devin Rousso
Comment 3 2020-06-25 17:38:34 PDT
Created attachment 402833 [details] Patch
EWS Watchlist
Comment 4 2020-06-25 17:39:12 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Devin Rousso
Comment 5 2020-06-25 17:42:11 PDT
Created attachment 402834 [details] Patch oops, forgot to rebase the inspector protocl tests
Blaze Burg
Comment 6 2020-07-07 14:53:53 PDT
Comment on attachment 402834 [details] Patch r=me
Devin Rousso
Comment 7 2020-07-07 15:01:40 PDT
Comment on attachment 402834 [details] Patch I don't think we want this to land just yet :)
Joseph Pecoraro
Comment 8 2020-07-07 18:53:12 PDT
Oops, I had reviewed but forgot to submit. r=me as well. Awesome!
EWS
Comment 9 2020-08-24 10:32:01 PDT
Committed r266072: <https://trac.webkit.org/changeset/266072> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402834 [details].
Note You need to log in before you can comment on or make changes to this bug.