Bug 201294

Summary: Flaky Test: svg/custom/tabindex-order.html
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: Tools / TestsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, koivisto, krit, rniwa, sabouhallawa, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=199606
Bug Depends on:    
Bug Blocks: 50856    
Attachments:
Description Flags
Archive of layout-test-results from webkit-cq-01
none
Fixes the test again cdumez: review+

WebKit Commit Bot
Reported 2019-08-29 01:23:42 PDT
This is an automatically generated bug from the commit-queue. svg/custom/tabindex-order.html has been flaky on the commit-queue. svg/custom/tabindex-order.html was authored by krit@webkit.org and rniwa@webkit.org. https://trac.webkit.org/browser/trunk/LayoutTests/svg/custom/tabindex-order.html The commit-queue just saw svg/custom/tabindex-order.html flake (text diff) while processing attachment 377554 [details] on bug 201290. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6 The bots will update this with information from each new failure. If you believe this bug to be fixed or invalid, feel free to close. The bots will re-open if the flake re-occurs. If you would like to track this test fix with another bug, please close this bug as a duplicate. The bots will follow the duplicate chain when making future comments.
Attachments
Archive of layout-test-results from webkit-cq-01 (3.19 MB, application/zip)
2019-08-29 01:23 PDT, WebKit Commit Bot 		no flags
Details
Fixes the test again (1.72 KB, patch)
2019-08-29 14:29 PDT, Ryosuke Niwa 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2019-08-29 01:23:43 PDT
Created attachment 377560 [details] Archive of layout-test-results from webkit-cq-01
Ryan Haddad
Comment 2 2019-08-29 12:11:01 PDT
This was caused by https://trac.webkit.org/changeset/249237/webkit --- /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/svg/custom/tabindex-order-expected.txt +++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/svg/custom/tabindex-order-actual.txt @@ -32,7 +32,6 @@ id: c tabindex: 1 [object SVGEllipseElement] is focused. id: b tabindex: 1 [object SVGGElement] is focused. id: a tabindex: 1 [object SVGCircleElement] is focused. -id: k tabindex: 0 [object SVGPolygonElement] is focused. Test finished
Ryosuke Niwa
Comment 3 2019-08-29 13:19:29 PDT
Hm... I can't reproduce the flakiness either in debug or release on 10.14 but maybe I need 10.13. The flakiness dashboard suggests this: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=svg%2Fcustom%2Ftabindex-order.html
Ryosuke Niwa
Comment 4 2019-08-29 13:37:33 PDT
Alright, building on 10.13 now...
Ryosuke Niwa
Comment 5 2019-08-29 14:19:07 PDT
Hm... I can't reproduce this on high sierra with debt builds either.
Ryosuke Niwa
Comment 6 2019-08-29 14:29:16 PDT
Created attachment 377625 [details] Fixes the test again
Ryosuke Niwa
Comment 7 2019-08-29 14:51:24 PDT
Committed r249293: <https://trac.webkit.org/changeset/249293>
Radar WebKit Bug Importer
Comment 8 2019-08-29 14:52:20 PDT
<rdar://problem/54855749>
Note You need to log in before you can comment on or make changes to this bug.