Bug 202027

Summary: Remove some support for < iOS 13
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebKit Misc.Assignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201851
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2019-09-19 21:27:13 PDT
Remove some support for iOS versions less than 13.0. Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have values >= 130000. This means that expressions like "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True. After version checks have been removed, there are some cases where the preprocessor conditional looks like "#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)". These can be collapsed into "#if PLATFORM(COCOA)". This additional cleanup will be performed in a subsequent patch. This removal is part of a series of patches effecting the removal of dead code for old versions of iOS. This particular pass involves changes in which Joe Pecoraro was involved. These changes are isolated from other similar changes in order to facilitate the reviewing process.
Attachments
Patch (5.49 KB, patch)
2019-09-19 22:29 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-19 21:27:28 PDT
<rdar://problem/55547109>
Keith Rollin
Comment 2 2019-09-19 22:29:07 PDT
Created attachment 379206 [details] Patch
Alex Christensen
Comment 3 2019-09-19 22:46:42 PDT
Comment on attachment 379206 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379206&action=review > Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:222 > +#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY) These should just be PLATFORM(COCOA)
Keith Rollin
Comment 4 2019-09-19 22:55:08 PDT
I noted in my comment that I was going to perform that cleanup later. I'd like to keep each patch focussed on one type of change.
Keith Rollin
Comment 5 2019-09-20 12:53:34 PDT
So can I land it now anyway?
Alex Christensen
Comment 6 2019-09-20 13:19:56 PDT
I don't see any reason to do this in two changes. It's not hard to follow, and it would merge cleanly if we merged this to a branch.
Keith Rollin
Comment 7 2019-09-20 14:06:24 PDT
My reason is that this current patch is part of a much larger body of work, and I don't want to distract myself by going down other paths at the point. I have a process to manage all these details. Getting to the change you want is part of that, but it comes later.
Alex Christensen
Comment 8 2019-09-20 14:08:21 PDT
Comment on attachment 379206 [details] Patch I'm assuming that means you have a long train of git commits that would need rebasing if we changed this. Whatever. You should have a work flow that is more open to review changing things.
WebKit Commit Bot
Comment 9 2019-09-20 17:17:34 PDT
Comment on attachment 379206 [details] Patch Clearing flags on attachment: 379206 Committed r250171: <https://trac.webkit.org/changeset/250171>
WebKit Commit Bot
Comment 10 2019-09-20 17:17:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.