Bug 202274

Summary: Stop using testRunner.overridePreference() to turn on Page Cache
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 202293    
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
Patch none

Chris Dumez
Reported 2019-09-26 09:50:56 PDT
Stop using testRunner.overridePreference() to turn on Page Cache, as this does not work for WebKit2 when navigating cross-origin.
Attachments
WIP Patch (105.42 KB, patch)
2019-09-26 09:51 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (111.90 KB, patch)
2019-09-26 10:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (134.35 KB, patch)
2019-09-26 10:59 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-09-26 09:51:45 PDT
Created attachment 379650 [details] WIP Patch
Chris Dumez
Comment 2 2019-09-26 10:52:25 PDT
Created attachment 379659 [details] WIP Patch
Chris Dumez
Comment 3 2019-09-26 10:59:18 PDT
Created attachment 379661 [details] Patch
Alex Christensen
Comment 4 2019-09-26 11:47:23 PDT
Comment on attachment 379661 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379661&action=review > Tools/DumpRenderTree/TestRunner.cpp:587 > + RELEASE_ASSERT(!JSStringIsEqualToUTF8CString(key.get(), "WebKitUsesPageCachePreferenceKey")); These assertions seem a bit overboard. If it does nothing in WebKitTestRunner, future developers will realize that.
Chris Dumez
Comment 5 2019-09-26 11:52:55 PDT
(In reply to Alex Christensen from comment #4) > Comment on attachment 379661 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=379661&action=review > > > Tools/DumpRenderTree/TestRunner.cpp:587 > > + RELEASE_ASSERT(!JSStringIsEqualToUTF8CString(key.get(), "WebKitUsesPageCachePreferenceKey")); > > These assertions seem a bit overboard. If it does nothing in > WebKitTestRunner, future developers will realize that. I don't think it is that obvious, especially if somebody is writing a test for something does not not enter PageCache. Also, a RELEASE_ASSERT() in WKTR really does not hurt anything.
WebKit Commit Bot
Comment 6 2019-09-26 14:37:46 PDT
Comment on attachment 379661 [details] Patch Clearing flags on attachment: 379661 Committed r250398: <https://trac.webkit.org/changeset/250398>
WebKit Commit Bot
Comment 7 2019-09-26 14:37:48 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-09-26 14:38:17 PDT
<rdar://problem/55758960>
Note You need to log in before you can comment on or make changes to this bug.