Bug 203014

Summary: [iOS] Maintain the last Back/Forward cache entry when the application gets suspended
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 202293    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2019-10-15 16:45:13 PDT
Maintain the last Back/Forward cache entry when the application gets suspended. Homing out of MobileSafari currently kills all back/forward cache entries so no more fast back when coming back to MobileSafari.
Attachments
Patch (7.31 KB, patch)
2019-10-15 16:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-10-15 16:52:22 PDT
Created attachment 381038 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-10-15 16:52:43 PDT
<rdar://problem/56313898>
Geoffrey Garen
Comment 3 2019-10-15 17:06:47 PDT
Comment on attachment 381038 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381038&action=review r=me > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:593 > + if (m_prewarmedProcess) > + m_prewarmedProcess->shutDown(); Do we need to kill the prewarmed process? Jetsam can always kill it if needed. And it's a bummer to make the next link navigation slow in cases where you're multitasking. I guess this was our existing behavior, so my question may be out of scope of this patch. The same question applies to the process cache too.
Chris Dumez
Comment 4 2019-10-15 18:25:15 PDT
(In reply to Geoffrey Garen from comment #3) > Comment on attachment 381038 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381038&action=review > > r=me > > > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:593 > > + if (m_prewarmedProcess) > > + m_prewarmedProcess->shutDown(); > > Do we need to kill the prewarmed process? Jetsam can always kill it if > needed. And it's a bummer to make the next link navigation slow in cases > where you're multitasking. > > I guess this was our existing behavior, so my question may be out of scope > of this patch. Yes, this is not new behavior in this patch. I can follow-up and change this. > > The same question applies to the process cache too. Does not really matter since the process cache is currently disabled on iOS.
WebKit Commit Bot
Comment 5 2019-10-15 18:50:00 PDT
Comment on attachment 381038 [details] Patch Clearing flags on attachment: 381038 Committed r251174: <https://trac.webkit.org/changeset/251174>
WebKit Commit Bot
Comment 6 2019-10-15 18:50:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.