Bug 203107

Summary: XMLHttpRequest should not prevent entering the back/forward cache
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 203106, 203186    
Bug Blocks: 202293    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2019-10-17 09:59:48 PDT
XMLHttpRequest should not prevent entering the back/forward cache.
Attachments
Patch (23.62 KB, patch)
2019-10-17 16:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (23.62 KB, patch)
2019-10-19 16:42 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (31.93 KB, patch)
2019-10-19 20:26 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-10-17 16:02:50 PDT
Created attachment 381245 [details] Patch
Chris Dumez
Comment 2 2019-10-18 17:06:35 PDT
This is blocked on Bug 203106.
Chris Dumez
Comment 3 2019-10-19 16:42:17 PDT
Created attachment 381378 [details] Patch
Radar WebKit Bug Importer
Comment 4 2019-10-19 16:44:05 PDT
<rdar://problem/56438647>
Chris Dumez
Comment 5 2019-10-19 20:26:46 PDT
Created attachment 381388 [details] Patch
youenn fablet
Comment 6 2019-10-20 11:08:31 PDT
Comment on attachment 381388 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381388&action=review > Source/WebCore/ChangeLog:10 > + 1. We no longer cancel pending loads in the suspend() method as this may This means we will continue loads even if the page navigates away. If this is a large download or a load a la EventSource, we might spend some network resources for a suspended page. Is this ok? Do you know what other browsers are doing?
Chris Dumez
Comment 7 2019-10-20 12:33:36 PDT
(In reply to youenn fablet from comment #6) > Comment on attachment 381388 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381388&action=review > > > Source/WebCore/ChangeLog:10 > > + 1. We no longer cancel pending loads in the suspend() method as this may > > This means we will continue loads even if the page navigates away. > If this is a large download or a load a la EventSource, we might spend some > network resources for a suspended page. > Is this ok? Do you know what other browsers are doing? No, all loads are cancelled when entering the page cache.
Chris Dumez
Comment 8 2019-10-20 12:37:24 PDT
Comment on attachment 381388 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381388&action=review >>> Source/WebCore/ChangeLog:10 >>> + 1. We no longer cancel pending loads in the suspend() method as this may >> >> This means we will continue loads even if the page navigates away. >> If this is a large download or a load a la EventSource, we might spend some network resources for a suspended page. >> Is this ok? Do you know what other browsers are doing? > > No, all loads are cancelled when entering the page cache. We just don’t want to do it in the suspend() as it may fire events and we are not allowed to run script from inside suspend().
Chris Dumez
Comment 9 2019-10-21 08:17:25 PDT
Comment on attachment 381388 [details] Patch Clearing flags on attachment: 381388 Committed r251366: <https://trac.webkit.org/changeset/251366>
Chris Dumez
Comment 10 2019-10-21 08:17:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.