Bug 203490

Summary: results.webkit.org: Report more descriptive configurations for non-Apple ports
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, clopez, commit-queue, don.olmstead, ews-watchlist, glenn, lingho, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2019-10-28 10:02:08 PDT
Alexey pointed out to me that we're doing a pretty terrible job of distinguishing between our various different Linux ports in the results database. This carries over to WinCario too. Example: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-position%2Fposition-absolute-container-dynamic-002.html I'm going to suggest that we make the 'platform' for these match the 'port' from webkitpy and then, in the case of GTK, add a version_name based on the display driver.
Attachments
Patch (2.87 KB, patch)
2019-10-28 10:09 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (5.78 KB, patch)
2019-10-28 10:25 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-10-28 10:06:02 PDT
<rdar://problem/56658244>
Jonathan Bedard
Comment 2 2019-10-28 10:09:24 PDT
Created attachment 382078 [details] Patch
Carlos Alberto Lopez Perez
Comment 3 2019-10-28 10:17:53 PDT
Comment on attachment 382078 [details] Patch Patch looks fine. But there are some webkitpy test errors from the EWS.
Jonathan Bedard
Comment 4 2019-10-28 10:25:27 PDT
Created attachment 382080 [details] Patch
Jonathan Bedard
Comment 5 2019-10-28 10:32:00 PDT
(In reply to Carlos Alberto Lopez Perez from comment #3) > Comment on attachment 382078 [details] > Patch > > Patch looks fine. But there are some webkitpy test errors from the EWS. Yep, that's what I get for not running the tests locally before uploading...
Carlos Alberto Lopez Perez
Comment 6 2019-10-28 10:36:47 PDT
Comment on attachment 382080 [details] Patch r=me. thanks!
Aakash Jain
Comment 7 2019-10-28 10:42:21 PDT
Comment on attachment 382080 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382080&action=review > Tools/Scripts/webkitpy/port/gtk.py:256 > + configuration['platform'] = 'GTK' is the capitalization intention?
Jonathan Bedard
Comment 8 2019-10-28 10:43:55 PDT
(In reply to Aakash Jain from comment #7) > Comment on attachment 382080 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382080&action=review > > > Tools/Scripts/webkitpy/port/gtk.py:256 > > + configuration['platform'] = 'GTK' > > is the capitalization intention? It is, it's trying to match the behavior of the old database and buildbot: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#builder=GTK%20Linux%2064-bit%20Debug%20(Tests)
WebKit Commit Bot
Comment 9 2019-10-28 11:42:17 PDT
The commit-queue encountered the following flaky tests while processing attachment 382080 [details]: imported/w3c/web-platform-tests/css/css-position/position-absolute-container-dynamic-002.html bug 203473 (author: simon.fraser@apple.com) imported/w3c/web-platform-tests/css/css-position/position-absolute-crash-chrome-005.html bug 203474 (author: simon.fraser@apple.com) imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html bug 202003 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 10 2019-10-28 11:43:11 PDT
Comment on attachment 382080 [details] Patch Clearing flags on attachment: 382080 Committed r251661: <https://trac.webkit.org/changeset/251661>
WebKit Commit Bot
Comment 11 2019-10-28 11:43:13 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 12 2019-10-28 16:22:00 PDT
> Example: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-position%2Fposition-absolute-container-dynamic-002.html We should further standardize the naming. I see "Xvfb wk2 Release" on this link now, but that doesn't match any of the queue names on https://build.webkit.org/dashboard/
Jonathan Bedard
Comment 13 2019-10-28 16:33:28 PDT
(In reply to Alexey Proskuryakov from comment #12) > > Example: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-position%2Fposition-absolute-container-dynamic-002.html > > We should further standardize the naming. I see "Xvfb wk2 Release" on this > link now, but that doesn't match any of the queue names on > https://build.webkit.org/dashboard/ That would be GTK, but yeah, I agree, the name we're displaying isn't quite right.
Carlos Alberto Lopez Perez
Comment 14 2019-10-28 17:26:18 PDT
(In reply to Alexey Proskuryakov from comment #12) > > Example: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-position%2Fposition-absolute-container-dynamic-002.html > > We should further standardize the naming. I see "Xvfb wk2 Release" on this > link now, but that doesn't match any of the queue names on > https://build.webkit.org/dashboard/ For layout tests for GTK we basically have two types of bots: - Wayland - Xvfb (but the name Xvfb is usually omitted) So I suggest to remove "Xvfb" from the name here.
Note You need to log in before you can comment on or make changes to this bug.