Bug 203761

Created attachment 382632 [details] Patch

We're going to need to defer some pylint things for https://bugs.webkit.org/show_bug.cgi?id=204133.

Created attachment 383410 [details] Patch

Created attachment 383412 [details] Patch

Comment on attachment 383412 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383412&action=review > Tools/Scripts/webkitpy/style/optparser_unittest.py:-101 > - not against this change but is it really necessary for python3? > Tools/Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:85 > + self.assert_error(1 if sys.version_info > (3, 0) else 0, 'json/syntax', '<<<<<<< HEAD\n{\n}\n') Why is this different? Maybe add a comment

Comment on attachment 383412 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383412&action=review >> Tools/Scripts/webkitpy/style/optparser_unittest.py:-101 >> - > > not against this change but is it really necessary for python3? I thought it was originally, but no, it's not. The bug I was chasing here actually had to do with trying to run Python 3's pylint in Python 2. Decided to keep it anyways because it seems better than the previous code. >> Tools/Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:85 >> + self.assert_error(1 if sys.version_info > (3, 0) else 0, 'json/syntax', '<<<<<<< HEAD\n{\n}\n') > > Why is this different? Maybe add a comment Python 2 and 3 have a slightly different json parser which reports line numbers differently (0 vs 1 indexed)

(In reply to Jonathan Bedard from comment #6) > Comment on attachment 383412 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383412&action=review > > >> Tools/Scripts/webkitpy/style/optparser_unittest.py:-101 > >> - > > > > not against this change but is it really necessary for python3? > > I thought it was originally, but no, it's not. The bug I was chasing here > actually had to do with trying to run Python 3's pylint in Python 2. Decided > to keep it anyways because it seems better than the previous code. Since this is so much boilerplate I'd move that part into a different patch. rs=me > > >> Tools/Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:85 > >> + self.assert_error(1 if sys.version_info > (3, 0) else 0, 'json/syntax', '<<<<<<< HEAD\n{\n}\n') > > > > Why is this different? Maybe add a comment > > Python 2 and 3 have a slightly different json parser which reports line > numbers differently (0 vs 1 indexed) yeah add a comment then

Committed r252440: <https://trac.webkit.org/changeset/252440>

<rdar://problem/57174424>