Bug 204013

Summary: Captcha images render as blank white space
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: CompositingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, mdob, pdr, simon.fraser, uri, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
zalan: review+
Patch none

Simon Fraser (smfr)
Reported 2019-11-08 11:29:06 PST
reCaptcha in an iframe sometimes goes blank when the user clicks on one of the squares.
Attachments
Patch (19.33 KB, patch)
2019-11-08 19:05 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (30.21 KB, patch)
2019-11-11 16:13 PST, Simon Fraser (smfr) 		zalan: review+
DetailsFormatted DiffDiff
Patch (29.70 KB, patch)
2019-11-11 16:18 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2019-11-08 11:29:18 PST
rdar://problem/50095458
Simon Fraser (smfr)
Comment 2 2019-11-08 14:16:44 PST
I think what's happening here is that the visibility transition on the parent frame is adding a RenderLayer to the paint-order tree that has a "HasDescendantNeedingRequirementsTraversal" bit, but that bit doesn't propagate to the root so we fail to traverse the iframe, and thus never parent the iframe's layers.
Simon Fraser (smfr)
Comment 3 2019-11-08 19:05:01 PST
Created attachment 383195 [details] Patch
Simon Fraser (smfr)
Comment 4 2019-11-11 16:13:33 PST
Created attachment 383311 [details] Patch
Dean Jackson
Comment 5 2019-11-11 16:15:38 PST
Comment on attachment 383311 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383311&action=review > LayoutTests/ChangeLog:31 > +2019-11-08 Simon Fraser <simon.fraser@apple.com> > + > + Captcha images render as blank white space > + https://bugs.webkit.org/show_bug.cgi?id=204013 > + > + Reviewed by NOBODY (OOPS!). > + > + * compositing/visibility/resources/become-composited.html: Added. > + * compositing/visibility/resources/frame-with-visibility-change.html: Added. > + * compositing/visibility/visibility-change-in-subframe-expected.txt: Added. > + * compositing/visibility/visibility-change-in-subframe.html: Added. oops.
Simon Fraser (smfr)
Comment 6 2019-11-11 16:18:26 PST
Created attachment 383312 [details] Patch
Simon Fraser (smfr)
Comment 7 2019-11-11 18:00:03 PST
https://trac.webkit.org/changeset/252353/webkit
Uri Klar
Comment 8 2019-12-08 04:28:13 PST
What is the status of this issue? I can reproduce this in v13.0.3
Note You need to log in before you can comment on or make changes to this bug.