Bug 204952

Summary: Python 3: Add support in webkitpy.test
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, cdumez, commit-queue, ews-watchlist, glenn, rniwa, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=184986
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2019-12-06 11:13:08 PST
This will allow us to run test-webkitpy with Python3. Note that this change does not guarantee that all tests actually pass when running in Python 3, just that we can run the harness. I'm going to keep the existing Python 3 harness until all the tests are passing.
Attachments
Patch (25.62 KB, patch)
2019-12-06 11:25 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-12-06 11:25:31 PST
Created attachment 385029 [details] Patch
Stephanie Lewis
Comment 2 2019-12-06 13:42:22 PST
Comment on attachment 385029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385029&action=review > Source/WebKit/Scripts/webkit/messages_unittest.py:31 > + from StringIO import StringIO Why not use Unicode compact function here?
Jonathan Bedard
Comment 3 2019-12-06 13:48:45 PST
Comment on attachment 385029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385029&action=review >> Source/WebKit/Scripts/webkit/messages_unittest.py:31 >> + from StringIO import StringIO > > Why not use Unicode compact function here? Because this file has no webkitpy dependencies, we don't want to introduce one.
WebKit Commit Bot
Comment 4 2019-12-06 14:45:45 PST
Comment on attachment 385029 [details] Patch Clearing flags on attachment: 385029 Committed r253219: <https://trac.webkit.org/changeset/253219>
WebKit Commit Bot
Comment 5 2019-12-06 14:45:46 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-12-06 14:46:20 PST
<rdar://problem/57714030>
Note You need to log in before you can comment on or make changes to this bug.