Bug 205420

Created attachment 386015 [details] Patch

Comment on attachment 386015 [details] Patch rs=me

The commit-queue encountered the following flaky tests while processing attachment 386015 [details]: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.

Comment on attachment 386015 [details] Patch Clearing flags on attachment: 386015 Committed r253738: <https://trac.webkit.org/changeset/253738>

All reviewed patches have been landed. Closing bug.

<rdar://problem/58069617>

This update made imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch.html fail constantly on iOS History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fdom%2Fevents%2FEvent-dispatch-redispatch.html Diff: --- /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch-expected.txt +++ /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch-actual.txt @@ -1,7 +1,7 @@ click me! FAIL Redispatching DOMContentLoaded event after being dispatched assert_true: Received DOMContentLoaded event should be trusted before redispatching expected true got false -FAIL Redispatching mouseup event whose default action dispatches a click event assert_true: Received mouseup event should be trusted before redispatching from click event listener expected true got false +FAIL Redispatching mouseup event whose default action dispatches a click event assert_true: mouseup and click events should've been fired expected true got false PASS Redispatching event which is being dispatched -PASS Synthesizing click on button... (button width / height: 62.734375 / 18) +PASS Synthesizing click on button... (button width / height: 66.78125 / 20)

(In reply to Truitt Savell from comment #7) > This update made > imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch.html > fail constantly on iOS > > History: > https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb- > platform-tests%2Fdom%2Fevents%2FEvent-dispatch-redispatch.html > > Diff: > --- > /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test- > results/imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch- > expected.txt > +++ > /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test- > results/imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch- > actual.txt > @@ -1,7 +1,7 @@ > click me! > > FAIL Redispatching DOMContentLoaded event after being dispatched > assert_true: Received DOMContentLoaded event should be trusted before > redispatching expected true got false > -FAIL Redispatching mouseup event whose default action dispatches a click > event assert_true: Received mouseup event should be trusted before > redispatching from click event listener expected true got false > +FAIL Redispatching mouseup event whose default action dispatches a click > event assert_true: mouseup and click events should've been fired expected > true got false > PASS Redispatching event which is being dispatched > -PASS Synthesizing click on button... (button width / height: 62.734375 / > 18) > +PASS Synthesizing click on button... (button width / height: 66.78125 / 20) Looks like we need an iOS specific baseline then.

(In reply to Chris Dumez from comment #8) > (In reply to Truitt Savell from comment #7) > > This update made > > imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch.html > > fail constantly on iOS > > > > History: > > https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb- > > platform-tests%2Fdom%2Fevents%2FEvent-dispatch-redispatch.html > > > > Diff: > > --- > > /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test- > > results/imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch- > > expected.txt > > +++ > > /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test- > > results/imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch- > > actual.txt > > @@ -1,7 +1,7 @@ > > click me! > > > > FAIL Redispatching DOMContentLoaded event after being dispatched > > assert_true: Received DOMContentLoaded event should be trusted before > > redispatching expected true got false > > -FAIL Redispatching mouseup event whose default action dispatches a click > > event assert_true: Received mouseup event should be trusted before > > redispatching from click event listener expected true got false > > +FAIL Redispatching mouseup event whose default action dispatches a click > > event assert_true: mouseup and click events should've been fired expected > > true got false > > PASS Redispatching event which is being dispatched > > -PASS Synthesizing click on button... (button width / height: 62.734375 / > > 18) > > +PASS Synthesizing click on button... (button width / height: 66.78125 / 20) > > Looks like we need an iOS specific baseline then. Done in <https://trac.webkit.org/changeset/253756>.