Bug 205833

Summary: Add a move constructor to IDBResultData
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, achristensen, alecflett, beidson, cdumez, commit-queue, ews-watchlist, ggaren, jsbell, webkit-bug-importer, youennf, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sihui Liu
Reported 2020-01-06 14:25:00 PST
<rdar://problem/58146233>
Attachments
Patch (2.80 KB, patch)
2020-01-06 14:29 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (1.37 KB, patch)
2020-01-06 15:34 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2020-01-06 14:29:41 PST
Created attachment 386887 [details] Patch
youenn fablet
Comment 2 2020-01-06 15:02:04 PST
Comment on attachment 386887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386887&action=review > Source/WebCore/Modules/indexeddb/shared/IDBResultData.h:91 > + WEBCORE_EXPORT IDBResultData(IDBResultData&&); Can we just do IDBResultData(IDBResultData&&) = default given we do this for operator=(&&)? Or simply remove IDBResultData(const IDBResultData&)?
Sihui Liu
Comment 3 2020-01-06 15:34:50 PST
Created attachment 386899 [details] Patch
Sihui Liu
Comment 4 2020-01-06 15:35:40 PST
(In reply to youenn fablet from comment #2) > Comment on attachment 386887 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386887&action=review > > > Source/WebCore/Modules/indexeddb/shared/IDBResultData.h:91 > > + WEBCORE_EXPORT IDBResultData(IDBResultData&&); > > Can we just do IDBResultData(IDBResultData&&) = default given we do this for > operator=(&&)? Yes. > Or simply remove IDBResultData(const IDBResultData&)? Compile error.
WebKit Commit Bot
Comment 5 2020-01-07 14:06:56 PST
The commit-queue encountered the following flaky tests while processing attachment 386899 [details]: imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html bug 201481 (authors: shvaikalesh@gmail.com and youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2020-01-07 14:07:49 PST
Comment on attachment 386899 [details] Patch Clearing flags on attachment: 386899 Committed r254155: <https://trac.webkit.org/changeset/254155>
WebKit Commit Bot
Comment 7 2020-01-07 14:07:51 PST
All reviewed patches have been landed. Closing bug.
Sihui Liu
Comment 8 2020-01-08 16:07:21 PST
*** Bug 205816 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.