Bug 206458

Summary: Stop doing synchronous DecidePolicyForNavigationActionSync IPCs for initially empty document loads
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, dbates, ews-watchlist, ggaren, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 206442    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2020-01-17 16:14:12 PST
Bypass synchronous DecidePolicyForNavigationAction IPC for initially empty document loads.
Attachments
Patch (2.17 KB, patch)
2020-01-17 16:16 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (6.19 KB, patch)
2020-01-17 16:58 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (6.83 KB, patch)
2020-01-21 16:07 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.24 KB, patch)
2020-01-21 16:33 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.59 KB, patch)
2020-01-21 17:02 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-01-17 16:16:09 PST
Created attachment 388109 [details] Patch
Chris Dumez
Comment 2 2020-01-17 16:58:08 PST
Created attachment 388118 [details] Patch
Chris Dumez
Comment 3 2020-01-21 16:07:09 PST
Created attachment 388363 [details] Patch
Chris Dumez
Comment 4 2020-01-21 16:25:58 PST
Comment on attachment 388363 [details] Patch Brady suggest sending the IPC as async in this case and simply ignore the response. I am looking into this.
Chris Dumez
Comment 5 2020-01-21 16:33:14 PST
Created attachment 388372 [details] Patch
Chris Dumez
Comment 6 2020-01-21 17:02:00 PST
Created attachment 388375 [details] Patch
WebKit Commit Bot
Comment 7 2020-01-22 11:29:20 PST
The commit-queue encountered the following flaky tests while processing attachment 388375 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2020-01-22 11:29:53 PST
Comment on attachment 388375 [details] Patch Clearing flags on attachment: 388375 Committed r254930: <https://trac.webkit.org/changeset/254930>
WebKit Commit Bot
Comment 9 2020-01-22 11:29:55 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2020-01-22 15:47:40 PST
<rdar://problem/58814321>
Radar WebKit Bug Importer
Comment 11 2020-01-22 15:47:43 PST
<rdar://problem/58814324>
Note You need to log in before you can comment on or make changes to this bug.