Bug 206541

Summary: Remove ImageBuffer::sizeForDestinationSize()
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: CanvasAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, annulen, beidson, cdumez, cmarcelo, commit-queue, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, graouts, gyuyoung.kim, jer.noble, jsbell, kondapallykalyan, luiz, macpherson, menard, noam, pdr, philipj, ryuan.choi, schenney, sergio, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 206519    
Bug Blocks: 204955    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Said Abou-Hallawa
Reported 2020-01-21 10:11:29 PST
This function is currently does nothing. For CG ports, it scales a rect by the ratio backingStoreSize / internalSize which is always 1. The constructor ImageBuffer::ImageBuffer() sets m_size and m_data.backingStoreSize to the same value always. m_size = IntSize(scaledWidth, scaledHeight); m_data.backingStoreSize = m_size; For other ports ImageBuffer::sizeForDestinationSize() returns the passed rectangle.
Attachments
Patch (86.96 KB, patch)
2020-01-21 10:15 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (85.89 KB, patch)
2020-01-21 13:48 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (18.14 KB, patch)
2020-01-22 00:18 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (17.00 KB, patch)
2020-01-22 12:20 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2020-01-21 10:15:32 PST
Created attachment 388315 [details] Patch
Said Abou-Hallawa
Comment 2 2020-01-21 13:48:12 PST
Created attachment 388342 [details] Patch
Said Abou-Hallawa
Comment 3 2020-01-22 00:18:03 PST
Created attachment 388402 [details] Patch
Said Abou-Hallawa
Comment 4 2020-01-22 12:20:42 PST
Created attachment 388457 [details] Patch
WebKit Commit Bot
Comment 5 2020-01-22 13:31:43 PST
The commit-queue encountered the following flaky tests while processing attachment 388457 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2020-01-22 13:32:16 PST
Comment on attachment 388457 [details] Patch Clearing flags on attachment: 388457 Committed r254941: <https://trac.webkit.org/changeset/254941>
WebKit Commit Bot
Comment 7 2020-01-22 13:32:18 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-01-22 15:58:33 PST
<rdar://problem/58814730>
Note You need to log in before you can comment on or make changes to this bug.