Bug 207615

Summary: macCatalyst: Unable to grab scrollbar on editable text field
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Wenson Hsieh
Reported 2020-02-11 22:07:30 PST
<rdar://problem/59212993>
Attachments
Patch (2.75 KB, patch)
2020-02-11 22:14 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (3.23 KB, patch)
2020-02-11 22:30 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-02-11 22:14:22 PST
Created attachment 390493 [details] Patch
Tim Horton
Comment 2 2020-02-11 22:17:17 PST
Comment on attachment 390493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390493&action=review > Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:184 > + if ([NSStringFromClass(view.class) isEqualToString:@"_UIScrollViewScrollIndicator"] && [view.superview isKindOfClass:WKChildScrollView.class]) { NSStringFromClass every time is probably not a great plan. Maybe look up the class from string once, keep it, and use isKindOfClass? Or at least flip the conditions?
Wenson Hsieh
Comment 3 2020-02-11 22:22:49 PST
Comment on attachment 390493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390493&action=review >> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:184 >> + if ([NSStringFromClass(view.class) isEqualToString:@"_UIScrollViewScrollIndicator"] && [view.superview isKindOfClass:WKChildScrollView.class]) { > > NSStringFromClass every time is probably not a great plan. Maybe look up the class from string once, keep it, and use isKindOfClass? > > Or at least flip the conditions? Good catch! I'll cache the class in a static helper (using dispatch_once) and pass it into -isKindOfClass.
Wenson Hsieh
Comment 4 2020-02-11 22:30:10 PST
Created attachment 390494 [details] Patch
WebKit Commit Bot
Comment 5 2020-02-12 07:38:42 PST
The commit-queue encountered the following flaky tests while processing attachment 390494 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2020-02-12 07:39:20 PST
Comment on attachment 390494 [details] Patch Clearing flags on attachment: 390494 Committed r256433: <https://trac.webkit.org/changeset/256433>
WebKit Commit Bot
Comment 7 2020-02-12 07:39:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.